Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license file in Maven package for newer versions #354

Closed
desombre opened this issue Feb 3, 2023 · 2 comments
Closed

Missing license file in Maven package for newer versions #354

desombre opened this issue Feb 3, 2023 · 2 comments
Milestone

Comments

@desombre
Copy link

desombre commented Feb 3, 2023

The license file is missing in newer versions of the Maven packages source code. see: https://repo1.maven.org/maven2/com/fasterxml/jackson/dataformat/jackson-dataformat-cbor/2.14.2/ -> jackson-dataformat-cbor-2.14.2-sources.jar
In older versions e.g. 2.6.7 it was included.

@cowtowncoder
Copy link
Member

Hmmh. Odd, I do not recall this being done on purpose. But looking quickly at repo, it looks like LICENSE would not only be missing from source jars but also binary ones. I wonder if this has been the case since 2.10 when multiple individual repositories were merged; addition of another level may have made parent-level LICENSE not found by sub-modules.

Anyway: need to make this work. Thank you for reporting the issue, @desombre !

@cowtowncoder cowtowncoder added this to the 2.14.3 milestone Feb 5, 2023
@cowtowncoder
Copy link
Member

Fixed this for all dataformat modules (here and otherwise), backporting into 2.12 onwards (in off-chance there might be micro-patches or something). But will be included in 2.14.3 and 2.15.0 when those get released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants