Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telem RF - Unused state machine and misused buffer #40

Open
kb1lqd opened this issue Oct 27, 2016 · 0 comments
Open

Telem RF - Unused state machine and misused buffer #40

kb1lqd opened this issue Oct 27, 2016 · 0 comments

Comments

@kb1lqd
Copy link
Contributor

kb1lqd commented Oct 27, 2016

Located in Telem_RF.c

The variables below are used incorrectly or not at all and should be fixed. If there is no need for the structure it should be removed. The telem_rf_pkt_1_state_machine_data[] is used only for packet operations and not for the state machine and only used in a single function is seems. This should be corrected or the variable moved local in the single function it is used in.

//volatile TELEMETRY_RF_PACKET_STATE_MACHINE_STRUCT telem_rf_pkt_1_state_machine_struct; /**< RF telemetry state machine structure */
volatile unsigned char telem_rf_pkt_1_state_machine_data[TELEM_RF_PACKET_1_LEN]; /**< RF Telemetry data bytearray for use by the rf telemetry state machine */
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant