Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix util-db update --validate flag #904

Open
matejmode opened this issue Dec 9, 2023 · 4 comments
Open

Fix util-db update --validate flag #904

matejmode opened this issue Dec 9, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@matejmode
Copy link
Collaborator

Validate during update doesn't load db-hash correctly.

build/util-db update --chainid 1 --log debug --validate --db-tmp tmp/ --aida-db aida-db
...
2023/12/09 18:53:06 CRITICAL: DbHash not found in downloaded Patch - cannot perform validation. If you were missing only lachesis patch, this would be normal behaviour.
...
@matejmode matejmode self-assigned this Dec 9, 2023
@matejmode
Copy link
Collaborator Author

This is not priority error as it doesn't corrupt the database, and validation can be run right after getting this error.

@matejmode matejmode added the bug Something isn't working label Dec 9, 2023
@wsodsong
Copy link
Collaborator

Can you give a bit more information about this issue? What is the latest patch name or last block number or expected db-hash?

@matejmode
Copy link
Collaborator Author

The issue is that just during the update wrong db-hash is loaded to be compared against freshly downloaded patch. So there is an error. While everything else being correct. And even right after downloading with this fail you can correctly do util-db validate so this is not any blocking issue.

@wsodsong
Copy link
Collaborator

Since we already have util-db validate command. I like to suggest remove --validate option from util-db update command. We can always run util-db validate afterwards.

@matejmode matejmode self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants