Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrices should be constructed as Identity #827

Open
ASPePeX opened this issue Jul 12, 2023 · 0 comments
Open

Matrices should be constructed as Identity #827

ASPePeX opened this issue Jul 12, 2023 · 0 comments
Labels
easy first contribution enhancement

Comments

@ASPePeX
Copy link
Member

ASPePeX commented Jul 12, 2023

Currently parameterless constructors for Matrices initialize them with all zeros. This seems to be a pitfall (e.g #820). Since identity matrices are the neutral state, and zero matrices are not that useful anyways, I propose that expected behaviour would be to default to initializing matrices as identity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy first contribution enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ASPePeX