[Feature Request]: Only Allow Some Number of Blocks to Be Destroyed per Hour

[1whohears]

Mod

FTB Chunks + FTB Teams

Description

Idea 1

It would be cool if there was a configurable feature that only allowed some number of blocks to be destroyed in protected chunks per unit of time. For example lets say the config is set to 100 blocks per hour. An attacking player could only destroy 100 blocks, and then have to wait another hour before they could break blocks in the enemy territory again.

There could also be a configurable white list of blocks (chests/beds) that cannot be destroyed regardless. Or a config system where certain blocks can override the default block break rate. For example, only 1 chest can be destroyed per hour, everything else can be broken at 100 blocks per hour.

If implemented, server owners could decide to allow raids to damage blocks, but not completely destroy the entire base. This can nerf the strat where people simply build their bases deep underground so it's impossible to get inside and attack. Again everything would be configurable so if server owners don't like this feature they can disable it, or it should be disabled by default since it would be a new feature.

Idea 2

There is an additional feature that would probably be needed to make this work though.

You shouldn't be able to damage enemy chunks if no players on that team are not online and able to defend the chunks. That should be a configurable setting like everything else. And there should be some kind of configurable combat log timer. So players can't DC when they are being attacked.

Idea 3

There should also be an option where you are not allowed to enter enemy territory if they are not online. There are plenty of ways to get into bases (chorus fruit, ender pearl through block glitches, other unforseen glitches) and kill entities and what not to grief bases when they aren't online (overnight villager genocide). Preventing base entry is the easiest way to prevent this. Not sure what the best way to implement that though. TP back? Make it all configurable of course.

I can code

I am a mod dev, so I am willing to work on these features myself and contribute via pull request. I am of course not familiar with the code base yet though. So I would need some direction on what parts of the code base to study and possible ways to add this stuff. I would like to launch a server with these features in December. So if y'all can't work on these features, or can't complete it by December then please let me know so I can start working on it.

If y'all don't want these features in your base mods, would it be possible to add these features via an addon?

Thank you for your time and thoughts!

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

[1whohears]

I know y'all got to respond to over 300 issues which is prob why y'all haven't gotten back to me yet which is fine lol. Thus, I am going to begin working on these features myself. I have gotten more familiar with the code base for FTB Chunks and I have a "concept of a plan" lmao. It's a little confusing but I really like how the permission system in FTB Chunks is designed.

I am probably going to have to add additional Protection objects called something like BREAK_BLOCK cause otherwise there isn't way for to distinguish between placing a block and breaking a block. And then I'll add FTBChunksTeamData #canBreak which will be called by BREAK_BLOCK so block break counting can be handled in the canBreak.

I will be working from the 1.19 dev branch because the server I want to run will be forge 1.19.2. I am planning on making my changes only impact the server side so people that join my server can download stock FTB chunks and I can run the custom version on the server side. Cause I intend on submitting a pull request when I am done and have sufficiently testing everything, but I doubt y'all will be able to publish a version before I launch the server.

[1whohears]

Closing because I submitted a pull request. It has most of the feature ideas I described above. I didn't implement a per block item break rate (every block is treated the same), or a tp out of enemy territory setting. I can implement those some other time.