Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: notify nht client about protocol type change #17117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enkechen-panw
Copy link
Contributor

The protocol type is of interest to NHT clients. Comparea the field for changes.

The protocol type is of interest to NHT clients. Comparea the
field for changes.

Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
@donaldsharp
Copy link
Member

Can you point me to a place that this matters in a protocol? I'd like to understand this requirement change. Additionally this would clearly change behavior for both pim and bgpd in that they both assume that nht is only informing them of changes in what nexthops are being used. They both do a lot of work that could conceivably be completely unnecessary and I would not want changes in behavior here not be accounted for in the upper level protocols as well.

@enkechen-panw
Copy link
Contributor Author

@donaldsharp Here they are:

bgp_nexthop_update()
  bgp_process_nexthop_update()
           if (import_check && (nhr->type == ZEBRA_ROUTE_BGP ||
                             !prefix_same(&bnc->prefix, &nhr->prefix))) {
                SET_FLAG(bnc->change_flags, BGP_NEXTHOP_CHANGED);
                UNSET_FLAG(bnc->flags, BGP_NEXTHOP_VALID);

static_zebra_nexthop_update():

        if (nhr->type == ZEBRA_ROUTE_CONNECT) {
                if (static_nexthop_is_local(vrf->vrf_id, matched,
                                            nhr->prefix.family))
                        nhr->nexthop_num = 0;
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants