Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement: Eliminate time correction field as a required, always-present field and retain as an optional field present when needed #22

Open
krischer opened this issue Jan 3, 2018 · 13 comments

Comments

@krischer
Copy link
Contributor

krischer commented Jan 3, 2018

Simplification of MiniSEED2: Eliminate time correction field as a required, always-present field and retain as an optional field present when needed.

@chad-earthscope
Copy link
Member

miniSEED 2.x contains an always-present field, even though it was rarely used, in the fixed header for time corrections along with a flag indicating whether it had been applied to the record start time. This scenario requires readers to always check the flag and apply the time adjustment if needed to determine the correct start time. This is a no-brainer.

@krischer
Copy link
Contributor Author

krischer commented Jan 9, 2018

How does this mesh with #21? In my interpretation #21 would make the time correction field obsolete and any tool converting from MiniSEED2 to the new format would have to make the calculation if necessary and directly incorporate it into the record start time.

@chad-earthscope
Copy link
Member

In my interpretation #21 would make the time correction field obsolete and any tool converting from MiniSEED2 to the new format would have to make the calculation if necessary and directly incorporate it into the record start time.

This is exactly what I would expect as well. Unapplied time corrections are fixed when moving forward to NGF.

@krischer
Copy link
Contributor Author

Summary

(Please let me know if I missed a point or misunderstood something)

Please vote on:

  1. (Assuming Requirment: Simplify and improve record start time #21 gets a no) Should the time-correction field be optional? (Yes/No)
  2. (Assuming Requirment: Simplify and improve record start time #21 gets a yes) Should there be an optional flag "time-correction applied"?

@crotwell
Copy link

crotwell commented Jan 29, 2018

1 yes
2 no - this is a properly a provenance issue, but a datacenter could increment #13 data/publication version if/when time corrections are applied.

@chad-earthscope
Copy link
Member

  1. Yes. Assuming we have optional extra headers.
  2. No.

@kaestli
Copy link

kaestli commented Jan 30, 2018

  1. No (Assuming we avoid optional extra headers :)
  2. No

@ozym
Copy link

ozym commented Jan 30, 2018

  1. No
  2. No

@ketchum-usgs
Copy link

yes, use optional header if time is not right
no

@claudiodsf
Copy link

  1. (Assuming Requirment: Simplify and improve record start time #21 gets a no) Should the time-correction field be optional? (Yes/No)

Yes

  1. (Assuming Requirment: Simplify and improve record start time #21 gets a yes) Should there be an optional flag "time-correction applied"?

No. Agree with @crotwell on that this is a provenance issue

@ihenson-bsl
Copy link

  1. Yes
  2. No

2 similar comments
@ValleeMartin
Copy link

  1. Yes
  2. No

@JoseAntonioJara
Copy link

  1. Yes
  2. No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants