Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Swap use animated from react-native to react-native-reanimated so we have big performance gains in animations
Fixed Issues
$ #52920
PROPOSAL:
here
Tests
Text input
expected behavior:
the label above the text input should move up at the moment of focus on the input
label should return to its original place when focus on text input disappears.
Growl nottification
This is quite hard, the easiest way to do it is to manually add the code that will call it, you need to add the following code:
Growl.show('TEST NOTIFICATION HARDCODED ONLY AS AN EXAMPLE', CONST.GROWL.SUCCESS, 3000);
expected behavior:
A notification with a bounce-in effect containing the text will appear:
TEST NOTIFICATION HARDCODED ONLY AS AN EXAMPLE
Attachment modal:
Animated here is the appearance of the send button in the modal, the animation is not very visible but behaves the same as the one using animated
Offline tests
Are not needed
QA Steps
Same as the tests, in addition, you can also see other text inputs
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop