feat: new way to handle insets in the app #53250

kirillzyusko · 2024-11-28T15:17:00Z

Explanation of Change

Motivation for changes

We recently enabled edge-to-edge mode on android:

feat: edge-to-edge mode on Android #52392

which caused some regressions, mostly related to the bottom navigation bar and the content either having too much or to less spacing. As well as problems where when opening the keyboard the content would be either hidden behind the keyboard or would have too much spacing between the keyboard's edge.

This PR aims to fix all of those UI regressions

Problems with current implementation

The main problem for all of this is that there are different paths to handle safe area insets. As of now there are:

useSafeAreaBottomInset()
SafeAreaConsumer
useSafeAreaInsets()

Every screen and their child components was making their own guessing about how the bottom safe area should be handled, leading to inconsistencies. They have special conditions for different platforms, and combining them creates even more inconsistent results.

The strategy of this PR

Introduce an API that unifies the safe area handling, provides an equal interface for any platform and creates the same visual output across platforms.

Postulates:

The safe area bottom inset handling should be defined by the screen. It's not up to a child component of a screen whether it wants to obey the safe area inset or not, but to the most parent, the screen.
Only one API should be used when you want to handle the content insets
The new API should make sure that a safe area padding can only be applied once per screen
There is a default spacing, of 20px, that should usually be applied between the content and the bottom safe area inset (so that the content doesn't sit too close to the navigation bar). This spacing must explicitly be added by the screen's children, if the screen has to deal with the bottom safe area inset

Changes:

The <ScreenWrapper> component should handle the bottom safe area inset in the most places.
To the ScreenWrapperStatusContext we added whether a top or bottom padding has been applied
We introduced a new hook, which should be used everywhere you want to handle safe area insets called useStyledSafeAreaInsets.
If in a screen the safe area insets have already been applied this hook will simply return 0 values, ensuring child components don't risk adding safe area padding multiple times
We have a lot of screens that work like this:

<ScreenWrapper>
<FormProvider>
....

Earlier the bottom safe area inset was handled by the FormProvider. This has shifted now to <ScreenWrapper>, so we changed a lot of to enable the inset: <ScreenWrapper includeSafeAreaPaddingBottom /> (where before it was false)

Two reasons for this:

Its hard to understand how the safe area handling of a screen is working if its nested deep down in its children
FormProvider shows a button at the bottom. If the button adds the paddingBottom space for the safe area, and you open the keyboard, the safe area spacing will be visible between the keyboard and the button, creating too much space. Thus the parent screen should add the paddingBottom

There are ways to get around this using verticalKeyboardOffset but that greatly complicates the code

Future

We deprecated useSafeAreaBottomInset and SafeAreaConsumer in this PR. We want to look into all of their usages carefully and eventually remove them entirely
From now on, when building new features, the developer should first try to use ScreenWrapper's includeSafeAreaPaddingBottom prop. If they need to customize the behaviour they should use useSafeAreaBottomInset
A good example for a custom behaviour is when your screen renders a ScrollView where you want the content to be underneath the status bar as well in this case you would apply the padding to the content of the list:

const { safeAreaPaddingBottomStyle } = useSafeAreaBottomInset()

<ScreenWrapper includeSafeAreaPaddingBottom={false}>
<ScrollView contentContainerStyle={safeAreaPaddingBottomStyle}>

Fixed Issues

$ #53183
$ #53207
$ #53217
$ #53221
$ #53192
PROPOSAL: N/A

Tests

Verify that [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Web - Expense - Submit button on confirmation page has extra bottom margin #53161 is not reproducible
Verify that [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Video - Video controls are too close to the device navigation buttons #53215 is not reproducible
Verify that [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN #53205 is not reproducible
Verify that bottom/top padding works in the same way as current staging app

Offline tests

N/A

QA Steps

Verify that [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Web - Expense - Submit button on confirmation page has extra bottom margin #53161 is not reproducible
Verify that [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Video - Video controls are too close to the device navigation buttons #53215 is not reproducible
Verify that [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - LHN - Extra space at the bottom of LHN #53205 is not reproducible
Verify that bottom/top padding works in the same way as current staging app

PR Author Checklist

Screenshots/Videos

Android: Native

telegram-cloud-document-2-5354803205601516843.mp4

Android: mWeb Chrome

telegram-cloud-document-2-5354803205601516836.mp4

iOS: Native

new-insets-trimmed.mp4

iOS: mWeb Safari

ScreenRecording_11-29-2024.6-27-34.PM_1.MP4

MacOS: Chrome / Safari

MacOS: Desktop

src/hooks/useEdgeSpacing/index.ts

src/hooks/useStyledSafeAreaInsets.ts

Co-authored-by: edug <gedu@users.noreply.github.com>

hannojg · 2024-11-28T18:33:21Z

stepping out quickly, will wrap that PR up in a few hours!

github-actions · 2024-11-28T23:06:59Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

melvin-bot · 2024-11-28T23:07:32Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-11-28T23:49:52Z

BUG

Buttons overlapping with the screen

allroundexperts · 2024-11-28T23:52:30Z

BUG

Abnormally large bottom padding.

allroundexperts · 2024-11-28T23:54:34Z

BUG

Save button not consistent across screens

Screen.Recording.2024-11-29.at.4.53.45.AM.mov

allroundexperts · 2024-11-28T23:57:04Z

BUG

Buttons overlapping here as well.

kirillzyusko · 2024-11-29T11:47:07Z

Abnormally large bottom padding.

Fixed in 9901700

kirillzyusko · 2024-11-29T17:37:24Z

Alright, I believe this PR is ready for another round of review 😊

ZhenjaHorbach · 2024-11-29T18:45:22Z

I found a small bug
I'm not sure which version is correct (But looks like the year screen is wrong )
But the padding at the bottom of the year and time zone screen are slightly different

kirillzyusko · 2024-11-29T18:51:40Z

But looks like the year screen is wrong

Fixed @ZhenjaHorbach ❤️

ZhenjaHorbach · 2024-11-29T18:54:40Z

Workspace list screen
The same thing

ZhenjaHorbach · 2024-11-29T19:27:25Z

One more

2024-11-29.20.26.56.mov

2024-11-29.20.28.11.mov

ZhenjaHorbach · 2024-11-29T20:07:06Z

@mountiny
As for me the changes look good !
I can fill out the checklist
Or is it better to wait for @allroundexperts to additionally made a double checking from his side ?

mountiny · 2024-11-30T00:10:15Z

@ZhenjaHorbach @allroundexperts please add the checklist whoever is ready and we can merge this one

ZhenjaHorbach · 2024-11-30T09:23:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://drive.google.com/drive/folders/1wfbYDmllorbgSoFgr3_MF3vpWcMrh4r2?usp=sharing

Android: mWeb Chrome

https://drive.google.com/drive/folders/1iBHleN7bEogGbCSwsaD_6JJgRATYsBqS?usp=sharing

iOS: Native

https://drive.google.com/drive/folders/1wfbYDmllorbgSoFgr3_MF3vpWcMrh4r2?usp=sharing

iOS: mWeb Safari

https://drive.google.com/drive/folders/1iBHleN7bEogGbCSwsaD_6JJgRATYsBqS?usp=sharing

MacOS: Chrome / Safari

https://drive.google.com/drive/folders/1rXHvup-hIdAYDQU8mtL8dUaqFkO_BrOK?usp=sharing

MacOS: Desktop

https://drive.google.com/drive/folders/1rXHvup-hIdAYDQU8mtL8dUaqFkO_BrOK?usp=sharing

ZhenjaHorbach · 2024-11-30T11:11:48Z

We have some eslint issues
But the issues are related to withOnyx

so LGTM !

mountiny · 2024-11-30T13:35:01Z

Merge conflicts

…dling

mountiny · 2024-11-30T19:00:39Z

ESLint failing because of the useOnyx so that is fine on such PR

From https://github.com/Expensify/App
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> origin/main

> new.expensify@[9](https://github.com/Expensify/App/actions/runs/12098304413/job/33734621362?pr=53250#step:4:10).0.69-1 lint-changed
> NODE_OPTIONS=--max_old_space_size=8192 eslint --max-warnings=0 --config ./.eslintrc.changed.js $(git diff --diff-filter=AM --name-only origin/main HEAD -- "*.ts" "*.tsx")

This is not a desktop build, adding babel-plugin-annotate-react
babel.config.js
  - api.version: 7.24.5
  - api.env: development
  - process.env.NODE_ENV: undefined
  - process.env.BABEL_ENV: undefined
  - running in:  undefined

/home/runner/work/App/App/src/pages/EnablePayments/EnablePaymentsPage.tsx
  95:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/GroupChatNameEditPage.tsx
  120:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/NewChatConfirmPage.tsx
  188:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/TeachersUnite/IntroSchoolPrincipalPage.tsx
  137:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/TeachersUnite/KnowATeacherPage.tsx
  143:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/iou/request/step/IOURequestStepCurrency.tsx
  93:40  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/iou/request/step/IOURequestStepDate.tsx
  144:36  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/iou/request/step/IOURequestStepDescription.tsx
  176:43  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/iou/request/step/IOURequestStepMerchant.tsx
  147:9  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/iou/request/step/IOURequestStepWaypoint.tsx
  252:9  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/settings/Profile/CustomStatus/SetDatePage.tsx
  84:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/settings/Profile/CustomStatus/StatusClearAfterPage.tsx
  225:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/settings/Report/RoomNamePage.tsx
  125:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/tasks/NewTaskDescriptionPage.tsx
  [10](https://github.com/Expensify/App/actions/runs/12098304413/job/33734621362?pr=53250#step:4:11)5:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/tasks/NewTaskDetailsPage.tsx
  [14](https://github.com/Expensify/App/actions/runs/12098304413/job/33734621362?pr=53250#step:4:15)9:16  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

/home/runner/work/App/App/src/pages/tasks/NewTaskTitlePage.tsx
  96:[16](https://github.com/Expensify/App/actions/runs/12098304413/job/33734621362?pr=53250#step:4:17)  error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

This is a higher order component that provides the ability to map a state property directly to
something in Onyx (a key/value store). That way, as soon as data in Onyx changes, the state will be set and the view
will automatically change to reflect the new data  deprecation/deprecation

✖ 16 problems (16 errors, 0 warnings)

mountiny

One NAB comment, thanks for clearing this up and thanks @allroundexperts and @ZhenjaHorbach for review and testing

mountiny · 2024-11-30T19:02:09Z

src/components/Form/FormWrapper.tsx

            <FormElement
                key={formID}
                ref={formContentRef}
-                style={[style, safeAreaPaddingBottomStyle.paddingBottom ? safeAreaPaddingBottomStyle : styles.pb5]}
+                // Note: the paddingBottom is only grater 0 if no parent has applied the inset yet:


Suggested change

// Note: the paddingBottom is only grater 0 if no parent has applied the inset yet:

// Note: the paddingBottom is only greater than 0 if no parent has applied the inset yet:

melvin-bot · 2024-11-30T19:12:31Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2024-11-30T19:12:53Z

Not emergency, I have explained above why the test has been failing

OSBotify · 2024-11-30T19:20:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

feat: new way to handle insets in the app

d1c57ec

gedu reviewed Nov 28, 2024

View reviewed changes

src/hooks/useEdgeSpacing/index.ts Outdated Show resolved Hide resolved

adamgrzybowski reviewed Nov 28, 2024

View reviewed changes

src/hooks/useStyledSafeAreaInsets.ts Outdated Show resolved Hide resolved

hannojg and others added 3 commits November 28, 2024 19:04

Update src/hooks/useEdgeSpacing/index.ts

8e76218

Co-authored-by: edug <gedu@users.noreply.github.com>

add const import

73cee7a

fix safeAreaPaddingBottomStyle

f08991f

hannojg added 2 commits November 28, 2024 23:56

fix a few screens

69c8e29

fix workspace invite page

5832b1b

mountiny added the Ready To Build label Nov 28, 2024

mountiny marked this pull request as ready for review November 28, 2024 23:07

mountiny requested a review from a team as a code owner November 28, 2024 23:07

melvin-bot bot requested a review from lakchote November 28, 2024 23:07

melvin-bot bot removed the request for review from a team November 28, 2024 23:07

mountiny requested review from allroundexperts and mountiny November 28, 2024 23:10

This comment has been minimized.

Sign in to view

mountiny assigned hannojg Nov 29, 2024

mountiny mentioned this pull request Nov 29, 2024

Android - Expense - Save button moves up and down when keyboard is open #53183

Open

8 tasks

hannojg and others added 3 commits November 29, 2024 12:08

wip

c7ffc53

fix: search filter search page

9901700

fix profile page spacing

0dfa4c2

fix workspace more features page

1f76a0e

fix: 53207

c9b8162

mountiny requested a review from ZhenjaHorbach November 29, 2024 18:11

kirillzyusko added 3 commits November 29, 2024 19:14

fix: onboarding keyboard -> button padding

fc2cfdd

fix: verification modal missing top padding

b0a2c51

fix: 53192

69ee93e

fix: year modal wrong padding

064b321

fix: wrong bottom padding on workspace selection screen

e5d7da8

fix: category selector modal

3061183

Expensify deleted a comment from allroundexperts Nov 30, 2024

ZhenjaHorbach approved these changes Nov 30, 2024

View reviewed changes

Merge branch 'main' into feat/screen-wrapper-better-inset-padding-han…

e365e1e

…dling

mountiny approved these changes Nov 30, 2024

View reviewed changes

mountiny merged commit 3cc88f5 into Expensify:main Nov 30, 2024
16 of 17 checks passed

melvin-bot bot added the Emergency label Nov 30, 2024

mountiny removed the Emergency label Nov 30, 2024

mountiny mentioned this pull request Dec 1, 2024

Android - Navigation bar is white, FAB and more options menu overlap with navigation bar #53337

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new way to handle insets in the app #53250

feat: new way to handle insets in the app #53250

kirillzyusko commented Nov 28, 2024 •

edited by mountiny

Loading

hannojg commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024

melvin-bot bot commented Nov 28, 2024

This comment has been minimized.

allroundexperts commented Nov 28, 2024

allroundexperts commented Nov 28, 2024

allroundexperts commented Nov 28, 2024

allroundexperts commented Nov 28, 2024

kirillzyusko commented Nov 29, 2024

kirillzyusko commented Nov 29, 2024

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

kirillzyusko commented Nov 29, 2024

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

mountiny commented Nov 30, 2024

ZhenjaHorbach commented Nov 30, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 30, 2024 •

edited

Loading

mountiny commented Nov 30, 2024

mountiny commented Nov 30, 2024

mountiny left a comment

mountiny Nov 30, 2024

melvin-bot bot commented Nov 30, 2024

mountiny commented Nov 30, 2024

OSBotify commented Nov 30, 2024

	// Note: the paddingBottom is only grater 0 if no parent has applied the inset yet:
	// Note: the paddingBottom is only greater than 0 if no parent has applied the inset yet:

feat: new way to handle insets in the app #53250

feat: new way to handle insets in the app #53250

Conversation

kirillzyusko commented Nov 28, 2024 • edited by mountiny Loading

Explanation of Change

Motivation for changes

Problems with current implementation

The strategy of this PR

Future

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hannojg commented Nov 28, 2024 • edited Loading

github-actions bot commented Nov 28, 2024

melvin-bot bot commented Nov 28, 2024

This comment has been minimized.

allroundexperts commented Nov 28, 2024

allroundexperts commented Nov 28, 2024

allroundexperts commented Nov 28, 2024

allroundexperts commented Nov 28, 2024

kirillzyusko commented Nov 29, 2024

kirillzyusko commented Nov 29, 2024

ZhenjaHorbach commented Nov 29, 2024 • edited Loading

kirillzyusko commented Nov 29, 2024

ZhenjaHorbach commented Nov 29, 2024 • edited Loading

ZhenjaHorbach commented Nov 29, 2024 • edited Loading

ZhenjaHorbach commented Nov 29, 2024 • edited Loading

mountiny commented Nov 30, 2024

ZhenjaHorbach commented Nov 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ZhenjaHorbach commented Nov 30, 2024 • edited Loading

mountiny commented Nov 30, 2024

mountiny commented Nov 30, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny Nov 30, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Nov 30, 2024

mountiny commented Nov 30, 2024

OSBotify commented Nov 30, 2024

kirillzyusko commented Nov 28, 2024 •

edited by mountiny

Loading

hannojg commented Nov 28, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 29, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 30, 2024 •

edited

Loading

ZhenjaHorbach commented Nov 30, 2024 •

edited

Loading