feature: Add loading indicator when ReconnectApp is running #52272

nkdengineer · 2024-11-08T17:40:54Z

Details

Fixed Issues

$ #46611
PROPOSAL: #46611 (comment)

Tests

Login to app
Go to offline mode
Back to online mode
Verify that: loading indicator is displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to app
Go to offline mode
Back to online mode
Verify that: loading indicator is displayed

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-11-12T15:49:04Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-11-12T15:54:36Z

src/styles/index.ts

+            height: 2,
+            width: '100%',
+            backgroundColor: theme.border,
+            borderRadius: 5,


NAB but why 5? If the height is only 2 total, couldn't the border radius just be 2 as well?

@nkdengineer outstanding q here :)

getusha · 2024-11-12T16:59:55Z

@nkdengineer what did we change here? what was the issue?

nkdengineer · 2024-11-12T17:03:39Z

Using runOnJS to change isVisible within the animation may cause additional re-renders and other unintended effects.
I updated to remove isVisible and runOnJS and use opacity.value instead of isVisible.

nkdengineer · 2024-11-20T03:03:18Z

@getusha friendly bump

getusha · 2024-11-25T11:45:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-25.at.2.28.59.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-11-25.at.2.15.33.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-11-26.at.10.25.05.at.night.mov

iOS: mWeb Safari

Screen.Recording.2024-11-25.at.2.18.00.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-25.at.2.12.46.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-11-25.at.2.21.44.in.the.afternoon.mov

srikarparsi · 2024-11-26T18:58:19Z

Hi @getusha, how is this coming along? Do you think we can get this merged today or tomorrow?

getusha · 2024-11-26T19:22:33Z

I'll try to wrap this up today 🙇

getusha · 2024-11-26T19:24:25Z

@nkdengineer
The indicator isn't animated following this step

Troubleshoot > Force offline > Clear cache and restart
Navigate to Inbox
Navigate to search
Navigate back to Inbox

Screen.Recording.2024-11-26.at.10.20.12.at.night.mov

nkdengineer · 2024-11-29T05:36:37Z

@getusha Fixed this bug.

nkdengineer added 2 commits November 9, 2024 00:38

feature: Add loading indicator when ReconnectApp is running

1c3c035

fix lint

c8f048a

srikarparsi self-requested a review November 10, 2024 21:33

srikarparsi mentioned this pull request Nov 10, 2024

[$250] [New feature] Add loading indicator when ReconnectApp is running #46611

Open

nkdengineer added 3 commits November 12, 2024 16:07

Merge branch 'main' into fix/46611-re-create

c69bf57

remove isVisible shared value

a3dcad3

Merge branch 'main' into fix/46611-re-create

7bc1067

nkdengineer marked this pull request as ready for review November 12, 2024 15:48

nkdengineer requested review from a team as code owners November 12, 2024 15:48

melvin-bot bot requested review from getusha and removed request for a team November 12, 2024 15:49

shawnborton reviewed Nov 12, 2024

View reviewed changes

nkdengineer added 6 commits November 27, 2024 15:13

Merge branch 'main' into fix/46611-re-create

b88bc5d

resolve conflict

0309518

fix lint

cd37b51

fix border radius

7e16699

merge main

2d79dbc

fix loading bar animation doesn't work

4015f65

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Add loading indicator when ReconnectApp is running #52272

feature: Add loading indicator when ReconnectApp is running #52272

nkdengineer commented Nov 8, 2024

melvin-bot bot commented Nov 12, 2024

shawnborton Nov 12, 2024

getusha Nov 26, 2024

getusha commented Nov 12, 2024

nkdengineer commented Nov 12, 2024

nkdengineer commented Nov 20, 2024

getusha commented Nov 25, 2024 •

edited

Loading

srikarparsi commented Nov 26, 2024

getusha commented Nov 26, 2024

getusha commented Nov 26, 2024

nkdengineer commented Nov 29, 2024

feature: Add loading indicator when ReconnectApp is running #52272

Are you sure you want to change the base?

feature: Add loading indicator when ReconnectApp is running #52272

Conversation

nkdengineer commented Nov 8, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 12, 2024

shawnborton Nov 12, 2024

Choose a reason for hiding this comment

getusha Nov 26, 2024

Choose a reason for hiding this comment

getusha commented Nov 12, 2024

nkdengineer commented Nov 12, 2024

nkdengineer commented Nov 20, 2024

getusha commented Nov 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

srikarparsi commented Nov 26, 2024

getusha commented Nov 26, 2024

getusha commented Nov 26, 2024

nkdengineer commented Nov 29, 2024

getusha commented Nov 25, 2024 •

edited

Loading