Fix navigation issue for reconciliation #51359

twilight2294 · 2024-10-23T18:56:32Z

Details

Fixed Issues

$ #50498
PROPOSAL: #50498 (comment)

Tests

Precondition:

Expensify Card is enabled.
Bank account is added in Expensify Card page.
Workspace is connected to QBO.

Open App
Go to workspace settings > Accounting.
Click Card reconciliation.
Toggle on Continuous Reconciliation.
Select an account.
Click Reconciliation account.

Verify that on clicking Reconciliation account we get redirected to new RHP

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Precondition:

Expensify Card is enabled.
Bank account is added in Expensify Card page.
Workspace is connected to QBO.

Open App
Go to workspace settings > Accounting.
Click Card reconciliation.
Toggle on Continuous Reconciliation.
Select an account.
Click Reconciliation account.

Verify that on clicking Reconciliation account we get redirected to new RHP

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-24.at.12.48.39.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-24.at.12.52.16.AM.mov

iOS: Native

Screen.Recording.2024-10-24.at.12.41.33.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-24.at.12.38.42.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-24.at.12.34.21.AM.mov

MacOS: Desktop

Screen.Recording.2024-10-24.at.12.39.48.AM.mov

…ute after refresh and on submit

melvin-bot · 2024-10-23T18:56:37Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-10-28T08:32:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-13.at.7.55.58.in.the.morning.mov

Android: mWeb Chrome

Screen.Recording.2024-11-13.at.7.49.55.in.the.morning.mov

iOS: Native

Screen.Recording.2024-11-13.at.8.09.27.in.the.morning.mov

iOS: mWeb Safari

Screen.Recording.2024-11-13.at.7.49.55.in.the.morning.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-28.at.11.24.28.in.the.morning.mov

MacOS: Desktop

Screen.Recording.2024-11-13.at.8.12.01.in.the.morning.mov

getusha · 2024-10-28T08:35:32Z

@twilight2294 I can't see the account option on small screen sizes

twilight2294 · 2024-10-28T13:12:46Z

@twilight2294 I can't see the account option on small screen sizes

Can you try opening wallet page first and then do this? i guess there is an existing bug where we do not have the paymentBankAccountID and hence that field is hidden:

App/src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

Lines 109 to 114 in 4d65cc7

    
           {!!paymentBankAccountID && isContinuousReconciliationOn && ( 
        
               <MenuItemWithTopDescription 
        
                   style={styles.mt5} 
        
                   title={bankAccountTitle} 
        
                   description={translate('workspace.accounting.reconciliationAccount')} 
        
                   shouldShowRightIcon

twilight2294 · 2024-10-30T14:36:12Z

bump @getusha

getusha · 2024-11-04T16:02:15Z

@twilight2294 same after opening the wallet page, but i am getting navigated when toggling continuous reconciliation

Screen.Recording.2024-11-04.at.7.00.53.in.the.evening.mov

twilight2294 · 2024-11-05T20:30:05Z

@getusha can you try setting bank account again? idk why the bank account is not visible, and not changes in our PR might have caused it to hide, I'll merge main just to be safe, can you retest?

twilight2294 · 2024-11-09T11:50:00Z

@getusha can you please try again

getusha · 2024-11-11T02:13:09Z

@twilight2294 are you sure it's working for you? i tried with a different account, could you try?

twilight2294 · 2024-11-11T09:40:12Z

yes it does work, you are probably not seeing the option because of the following condition:

App/src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx

Line 109 in da595d4

{!!paymentBankAccountID && !!isContinuousReconciliationOn && (

Please make sure that paymentBankAccountID is present

Screen.Recording.2024-11-11.at.3.08.07.PM.mov

do let me know if i can help you any other way

getusha · 2024-11-13T04:52:51Z

Figured it out i had to select the account after enabling it

getusha

LGTM

NikkiWines

OSBotify · 2024-11-13T19:46:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-14T00:52:50Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

IuliiaHerets · 2024-11-14T11:51:50Z

This PR is failing for mWeb because of issue #52548

twilight2294 · 2024-11-14T11:54:52Z

@IuliiaHerets that is an existing bug present in the App, also see the testing steps, we fixed the issue of navigation only

github-actions · 2024-11-15T14:16:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

twilight2294 added 2 commits October 24, 2024 00:25

Update CardReconciliationPage to navigate to account settings page

849b819

Update ReconciliationAccountSettingsPage to goback to the settings ro…

39c6da0

…ute after refresh and on submit

twilight2294 requested a review from a team as a code owner October 23, 2024 18:56

melvin-bot bot requested review from getusha and removed request for a team October 23, 2024 18:56

Merge branch 'Expensify:main' into fixNavigationIssueForReconciliation

9d28f37

Merge branch 'Expensify:main' into fixNavigationIssueForReconciliation

b92ce48

getusha approved these changes Nov 13, 2024

View reviewed changes

melvin-bot bot requested a review from NikkiWines November 13, 2024 05:25

NikkiWines approved these changes Nov 13, 2024

View reviewed changes

NikkiWines merged commit 332438b into Expensify:main Nov 13, 2024
18 checks passed

github-actions bot mentioned this pull request Nov 14, 2024

Deploy Checklist: New Expensify 2024-11-14 #52512

Closed

47 tasks

IuliiaHerets mentioned this pull request Nov 14, 2024

[$250] QBO - "Reconciliation account" disappears after selecting it #52548

Open

8 tasks

melvin-bot bot mentioned this pull request Nov 15, 2024

[HOLD for payment 2024-11-22] [$250] Card reconciliation - Nothing happens after clicking on Reconciliation account #50498

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix navigation issue for reconciliation #51359

Fix navigation issue for reconciliation #51359

twilight2294 commented Oct 23, 2024 •

edited

Loading

melvin-bot bot commented Oct 23, 2024

getusha commented Oct 28, 2024 •

edited

Loading

getusha commented Oct 28, 2024

twilight2294 commented Oct 28, 2024 •

edited

Loading

twilight2294 commented Oct 30, 2024

getusha commented Nov 4, 2024

twilight2294 commented Nov 5, 2024

twilight2294 commented Nov 9, 2024

getusha commented Nov 11, 2024

twilight2294 commented Nov 11, 2024

getusha commented Nov 13, 2024

getusha left a comment

NikkiWines left a comment

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

IuliiaHerets commented Nov 14, 2024 •

edited

Loading

twilight2294 commented Nov 14, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024

Fix navigation issue for reconciliation #51359

Fix navigation issue for reconciliation #51359

Conversation

twilight2294 commented Oct 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 23, 2024

getusha commented Oct 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha commented Oct 28, 2024

twilight2294 commented Oct 28, 2024 • edited Loading

twilight2294 commented Oct 30, 2024

getusha commented Nov 4, 2024

twilight2294 commented Nov 5, 2024

twilight2294 commented Nov 9, 2024

getusha commented Nov 11, 2024

twilight2294 commented Nov 11, 2024

getusha commented Nov 13, 2024

getusha left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 13, 2024

github-actions bot commented Nov 14, 2024

IuliiaHerets commented Nov 14, 2024 • edited Loading

twilight2294 commented Nov 14, 2024 • edited Loading

github-actions bot commented Nov 15, 2024

twilight2294 commented Oct 23, 2024 •

edited

Loading

getusha commented Oct 28, 2024 •

edited

Loading

twilight2294 commented Oct 28, 2024 •

edited

Loading

IuliiaHerets commented Nov 14, 2024 •

edited

Loading

twilight2294 commented Nov 14, 2024 •

edited

Loading