Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Add the ability to apply SCP-914 effects if a person is standing in the OUTPUT section. #92

Open
iojforever opened this issue May 28, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@iojforever
Copy link

Config example:

  # Determines if 914 effects are exclusive, meaning only one can be applied each time a player is processed by 914.
  scp914_effects_exclusivity: bool
  # Whether or not SCPs are immune to effects gained from 914.
  scps_immune_to914_effects: bool
  # Determines if scp914_effect_chances works for a person who stands in output section.
  effects_applied_in_output: bool
   # Determines if scp914_class_changes works for a person who stands in output section.
  class_changes_applied_in_output: bool 
   # Determines if scp914_teleport_chances works for a person who stands in output section.
  teleport_applied_in_output: bool 

The effects applied, role changes, or teleportation options are very useful, but they are no use if the player is hiding in the OUTPUT section, as many of those who know that SCP-914 is set up to give you effects. This let players avoids all customization and essentially makes this section of the plugin almost useless.

Thank you.

@joker-119 joker-119 added enhancement New feature or request and removed needs testing labels May 31, 2022
@joker-119
Copy link
Contributor

The only real issue with this idea is, I would need to completely re-write how 914 stuff is handled, as it currently uses EXILED events to trigger the processing of effects on a per-player basis. Instead it would need to trigger off an event that doesn't even exist in exiled currently, then re-do 914's logic for getting players in the input, as well as duplicating it for getting players inside the output, and I'm unsure how servers would handle that performance penalty on servers with a large number of players.

Testing will be needed to determine the feasibility of this type of approach, as well as an EXILED update to add the necessary event to trigger the processing at the correct time.

For now, I am not entirely ruling out this idea, but I am not going to guarantee that it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants