Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve error handling of dataset names in region_series" #57

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dramanica
Copy link
Member

Reverts #56

@dramanica
Copy link
Member Author

@japilo Ouch, the dev vs master ended up being an issue. I am afraid I have to revert your changes, as they seem to create a number of problems with dev. We'll have to figure out where those issues come from. Your checks seem to trigger a number of datasets that were working before.

@dramanica dramanica merged commit d62932a into dev Sep 20, 2024
5 checks passed
@japilo
Copy link

japilo commented Sep 20, 2024

I'm kind of surprised! The datasets I wrote these checks for were datasets that were not working with the location_slice* functions. They were just there to provide informative error messages for things that were already problematic.

@dramanica
Copy link
Member Author

Sorry, misunderstanding, the problem is that datasets that were used in dev, which work fine at the moment, trigger the checks that you created for misshaped names. I am guessing that it might be an issue with empty varnames triggering the checks, or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants