Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad dependency in SpectatorTargetInfo ManiaTemplate #227

Open
snixtho opened this issue Nov 9, 2023 · 0 comments
Open

Bad dependency in SpectatorTargetInfo ManiaTemplate #227

snixtho opened this issue Nov 9, 2023 · 0 comments
Labels
bug Something isn't working Module: SpectatorTargetInfoModule module Issue related to a specific module or creation of a certain module. UI/UX Issue relating to the in-game overlay UI.

Comments

@snixtho
Copy link
Member

snixtho commented Nov 9, 2023

In the SpectatorTargetInfoModule the SpectatorTargetInfo template depends on Scoreboard.Components.PlayerRow.ClubTag from the scoreboard module.

First of all, it is not defined in the info.toml file that the SpectatorTargetInfoModule module depends on the Scoreboard module, and it will throw an exception if the scoreboard module is not loaded.

Second, I am not sure why a "club tag" component is part of the scoreboard module, and other modules will have to depend on the scoreboard module for this. Seems like an odd design decision. It would probably better to have such a component in the core instead.

@snixtho snixtho added bug Something isn't working module Issue related to a specific module or creation of a certain module. UI/UX Issue relating to the in-game overlay UI. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Module: SpectatorTargetInfoModule module Issue related to a specific module or creation of a certain module. UI/UX Issue relating to the in-game overlay UI.
Projects
None yet
Development

No branches or pull requests

1 participant