Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: refactor for schemes to have individual roots and ends files #17

Open
mikkokotila opened this issue Jul 4, 2023 · 3 comments
Open
Assignees

Comments

@mikkokotila
Copy link
Collaborator

The current system where they are all in one makes it very difficult to read and easy to make mistakes when editing. So the proposal is that we move into a system where each scheme lives in their own sub-folder of schemes folder, and has standard set of files:

  • SchemeName.py
  • roots.csv
  • ends.csv
  • exceptions.csv
@eroux
Copy link
Collaborator

eroux commented Jul 4, 2023

I think it's a good idea yes! the two MST schemas we envision could be in the same folder or not

@mikkokotila
Copy link
Collaborator Author

So I think the empty space before any characters on each row (which then gets removed by the code later) can be included in this scope as well.

@mikkokotila mikkokotila self-assigned this Jul 4, 2023
@eroux
Copy link
Collaborator

eroux commented Jul 4, 2023

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants