Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The file arguments account for deleted files as well #82

Open
LMaxence opened this issue May 11, 2022 · 3 comments
Open

The file arguments account for deleted files as well #82

LMaxence opened this issue May 11, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@LMaxence
Copy link
Member

When using the argument {matchedFiles} for instance in a hook, it will list changed file of the package as expected, but it will also list deleted files, leading to errors sometimes.

Here, the file `` was deleted which breaks my pre-commit hook and made me do a commit --no-verify.

image

@LMaxence LMaxence added the bug Something isn't working label May 13, 2022
@jeffvswanson
Copy link

I happened across this bug as well with renamed python files in mookme version 2.3.0.

@ghost
Copy link

ghost commented Jun 24, 2024

I opened a very primitive PR to fix this:

#132

@arthurio
Copy link
Contributor

Fixed by #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants