Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.1 has a regression #133

Open
rstreefland opened this issue Jul 18, 2024 · 6 comments
Open

v2.5.1 has a regression #133

rstreefland opened this issue Jul 18, 2024 · 6 comments

Comments

@rstreefland
Copy link

Hi, I've noticed that v2.5.1 seems to have a regression that is caused by this commit.

On MacOS Sonoma (14.1.1) I get this error:

git commit -m test --allow-empty
error: required option '-t, --type <type>' not specified

The error goes away if I remove the -- that was added to the command in the pre-commit hook:

npx @escape.tech/mookme -- run --type pre-commit --args "$1"%
@gorillanieto
Copy link

This is happening to me using the pre-commit.json file. I am not sure if I need to add a flag to the init command

@rezelute
Copy link

I am new to mookme (coming from Husky), installed the latest version, followed the docs but ran into the same problem with the pre-commit. Glad its not just me.

@alanmynah
Copy link

alanmynah commented Aug 13, 2024

this is what worked for me:
root_dir

rm -rf node_modules
rm -rf ./git/hooks

went to package.json and updated "postinstall": "npx @escape.tech/mookme@2.5.0 init <rest of your settings>
(needed to pin to 2.5.0)

then npm i and the error has gone away.

@zackrossman
Copy link

My team is seeing the same issue

@LMaxence
Copy link
Member

Hello !

I didn't realize how breaking this change was... Sorry for the disagreement. My understanding is that npm 10 introduces the breaking change of the "--".

I'll need to figure out something for supporting both npm < 10 and npm 10. In the meantime I would suggest applying @alanmynah 's fix or upgrade to npm 10 ?

@uncledru
Copy link

I'm on npm version 10.2.3 and still seeing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants