Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials/Secrets store #104

Open
benedikt-bartscher opened this issue Jan 16, 2023 · 1 comment
Open

Credentials/Secrets store #104

benedikt-bartscher opened this issue Jan 16, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@benedikt-bartscher
Copy link

Some typical pre-commit tasks, for example validation of .gitlab-ci.yml files, require auth to an external server. We should think about a global config file to store those secrets per-machine.

@LMaxence
Copy link
Member

Hello there !

I understand that this might be good add-on within Mookme, but it also feels to me like it is not up to the hooks manager to provide the correct hook execution environment.

In your specific case of a Gitlab CI, you can (and, probably, should) use the CI secrets feature to provide an environment. Afterwards, regardless of if the tool reads that environment on his own, or if you have to provide it in the command line invokation, you could provide it with nothing more within Mookme:

# CI secret
MY_SECRET=<SOMETHING>

-> pre-commit.json

{ 
  "steps": [{
    "name": "Something very very secret",
    "scripts": "do-something --secret=$MY_SECRET"
  }]
}

Hope that helps !

@LMaxence LMaxence added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants