Use the voi function, window and rescale of the decoded frame #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me being extracted
dougyau
changed the title
Enet4
reviewed
Nov 13, 2024
pixeldata/src/lib.rs
Outdated
Comment on lines
2168
to
2169
| } else if !rescale_data.is_empty() { | ||
| vec![rescale_data[0]] |
There was a problem hiding this comment.
Maybe even better:
Suggested change
| } else if !rescale_data.is_empty() { | |
| vec![rescale_data[0]] | |
| } else if let Some(resc) = rescale_data.get(0) { | |
| vec![*resc] |
The same trick can be done in the other cases.
There was a problem hiding this comment.
Switched the code from the if blocks to a functional style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding a single frame, frame_number is set to 1 but the voi_lut_function, the rescale and the window data is kept as an array. This change will use the data corresponding to the frame it will fallback to the first element if possible.