Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about constraints #429

Open
FelixNeutatz opened this issue Jul 22, 2022 · 1 comment
Open

Question about constraints #429

FelixNeutatz opened this issue Jul 22, 2022 · 1 comment

Comments

@FelixNeutatz
Copy link

Hi everybody,

I have a question about this line

If I have a constraint x <= 10. Then, I should implement the function:

def fc(x):
    return float(10.0-x)

Is this correct? I did not find any documentation on whether the constraint value is maximized or minimized.

Thank you for your help.

Best regards,
Felix

@apaleyes
Copy link
Collaborator

Hello! This particular loop is built with Probability Of Feasibility acquisition, which assumes c(x) <= 0, see here: https://github.com/EmuKit/emukit/blob/main/emukit/bayesian_optimization/acquisitions/probability_of_feasibility.py#L18

I do agree though the documentation shall be much clearer, we'll look into improving the docs of UnknownConstraintBO classes. Thanks to bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants