Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Update command doesn't update list of cores for currently running resen #73

Closed
asreimer opened this issue Nov 12, 2020 · 0 comments · Fixed by #74
Closed

[BUG]: Update command doesn't update list of cores for currently running resen #73

asreimer opened this issue Nov 12, 2020 · 0 comments · Fixed by #74
Labels
bug Something isn't working

Comments

@asreimer
Copy link
Contributor

After running the update command, the list of available cores within the currently running resen session is not refreshed.

This is because the update_core_list method doesn't call the __get_valid_cores method after successfully downloading the new cores.json file.

This means that users need to restart the resen shell before creating a new bucket.

Also, the documentation is completely missing any information about the update command.

I'll make a quick PR to fix these issues and we can do a minor release.

@asreimer asreimer added the bug Something isn't working label Nov 12, 2020
asreimer added a commit that referenced this issue Nov 12, 2020
@asreimer asreimer linked a pull request Nov 12, 2020 that will close this issue
@asreimer asreimer linked a pull request Nov 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant