Skip to content

Commit

Permalink
Commit triggered by a change on the main branch of helm-charts-dev
Browse files Browse the repository at this point in the history
  • Loading branch information
rconway committed Mar 8, 2024
1 parent 1b64bd3 commit 9e43546
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/application-hub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.0.57
version: 2.0.58

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
5 changes: 3 additions & 2 deletions charts/application-hub/files/hub/jupyter_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ async def pre_spawn_start(self, user, spawner):


jupyterhub_env = os.environ["JUPYTERHUB_ENV"].upper()
jupyterhub_hub_host = "application-hub-hub.proc"
app_hub_namespace = os.getenv("APP_HUB_NAMESPACE", "app-hub")
jupyterhub_hub_host = f"application-hub-hub.{app_hub_namespace}"
jupyterhub_single_user_image = os.environ["JUPYTERHUB_SINGLE_USER_IMAGE_NOTEBOOKS"]

resource_manager_workspace_prefix = os.environ["RESOURCE_MANAGER_WORKSPACE_PREFIX"]
Expand Down Expand Up @@ -235,7 +236,7 @@ async def pre_spawn_start(self, user, spawner):
c.KubeSpawner.node_selector = {"node-role.kubernetes.io/worker": "true"}

# Namespace
c.KubeSpawner.namespace = "proc"
c.KubeSpawner.namespace = app_hub_namespace

# User namespace
c.KubeSpawner.enable_user_namespaces = True
Expand Down
1 change: 1 addition & 0 deletions charts/application-hub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ jupyterhub:
extraEnv:
JUPYTERHUB_ENV: "dev"
JUPYTERHUB_SINGLE_USER_IMAGE_NOTEBOOKS: "jupyter/minimal-notebook:2343e33dec46"
APP_HUB_NAMESPACE: "app-hub"
STORAGE_CLASS: "managed-nfs-storage"
RESOURCE_MANAGER_WORKSPACE_PREFIX: "develop-user"

Expand Down

0 comments on commit 9e43546

Please sign in to comment.