Svelte 5 upgrade and fixed immediate breaking changes #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work! 🎇 CI is failing due to #594, but that's expected. Either downgrade eslint to 8.57 or migrate to the new configuration format. |
|
Migrated to new format; hopefully everything works as well as it did previously now! We have a lot of illegal self closing tags though... |
|
Went through and manually fixed most lint issues. Svelte 5 seems to introduce many type errors related to props with components though. Don't know how to fix those |
|
Seems like I have managed to break the first page for those who are not logged in. I am not sure how to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly solved form inside form issue by moving the dialog outside the outside form, and submit the form using the form attribute on the button elements