Skip to content
This repository has been archived by the owner on Nov 2, 2024. It is now read-only.

✨ Feature/bug - Anonymize image file names on user upload #1172

Open
alfredgrip opened this issue Jul 23, 2023 · 3 comments
Open

✨ Feature/bug - Anonymize image file names on user upload #1172

alfredgrip opened this issue Jul 23, 2023 · 3 comments
Labels
type: feature new functionality

Comments

@alfredgrip
Copy link
Contributor

Short description of the feature

Currently when someone uploads a profile picture, the name of the file uploaded is stored. See screenshot.
Screenshot 2023-07-23 at 19 29 46

Of course hero-image.jpg in the screen shot is not a concern since that is not a user profile picture.
This behavior is at least the case for profile pictures, I don't know if other parts are of the site is affected as well.

Why do you want this feature?

I guess most of the time an image you upload has some name like IMG_XXXX so it's not a big deal, but to have more user privacy a file name change could be implemented before it gets sent to the database. Either randomized or tied to user userid/stilid.
If your local file name was I_look_so_good_in_this_image, maybe you wouldn't want to share that with everyone.
Also I don't think there is any real reason to store this information.

I find that in https://github.com/Dsek-LTH/member-page/blob/3f71ea4440516048a965454ce938c01733ff9597/frontend/pages/members/[id]/change-profile-picture.tsx#L77 there is some randomization going on to the file name, but this isn't actually reflected as seen in the screenshot provided. So this might actually be a bug?

Who else could want this feature?

Probably not a high priority, and I guess most users don't even know about this behavior but it could be appreciated and shouldn't be hard to implement.

@alfredgrip alfredgrip added the type: feature new functionality label Jul 23, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DWWW 2023 Jul 23, 2023
@alfredgrip alfredgrip changed the title ✨ Feature/bug - Randomize image files on user upload ✨ Feature/bug - Randomize image file names on user upload Jul 23, 2023
@alfredgrip alfredgrip changed the title ✨ Feature/bug - Randomize image file names on user upload ✨ Feature/bug - Anonymize image file names on user upload Jul 23, 2023
@danieladugyan
Copy link
Contributor

If I recall correctly, this should already be fixed. Previously uploaded photos will still show their original names, but any photos uploaded now should get generated names.

@alfredgrip
Copy link
Contributor Author

Actually no, this is not the case. I just tried this, see screen recording. Seems to append some number to the file name this time at least.

586a3adf-d1b1-475b-9bc1-46ba0cc0238e.mp4

@danieladugyan
Copy link
Contributor

Actually no, this is not the case. I just tried this, see screen recording. Seems to append some number to the file name this time at least.

Alright, my bad. Appreciate the video 😄

@danieladugyan danieladugyan moved this from 🆕 New to 📋 Backlog in DWWW 2023 Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature new functionality
Projects
No open projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants