From ba07aec7f374e195104902676c22824af6cc709b Mon Sep 17 00:00:00 2001
From: lightlike <dnietfeld@outlook.com>
Date: Fri, 11 Oct 2019 14:29:41 +0200
Subject: [PATCH] Fix some small stuff (Updating)

---
 Drachenhorn.Core/Lang/LanguageManager.cs      |  6 +-
 Drachenhorn.Core/Settings/ISettings.cs        |  3 +-
 .../Converter/NullVisibilityConverter.cs      | 17 ++++-
 .../Drachenhorn.Desktop.csproj                |  3 -
 .../UI/Lang/TranslateExtension.cs             |  2 +-
 .../Common/SettingsViewControl.xaml           | 74 +++++++++----------
 .../Common/SettingsViewControl.xaml.cs        |  2 +-
 Drachenhorn.Desktop/UserSettings/Settings.cs  | 32 +-------
 .../UserSettings/SquirrelManager.cs           |  8 +-
 Drachenhorn.Desktop/commit                    |  1 -
 10 files changed, 61 insertions(+), 87 deletions(-)
 delete mode 100644 Drachenhorn.Desktop/commit

diff --git a/Drachenhorn.Core/Lang/LanguageManager.cs b/Drachenhorn.Core/Lang/LanguageManager.cs
index 9277f86..174ac5e 100644
--- a/Drachenhorn.Core/Lang/LanguageManager.cs
+++ b/Drachenhorn.Core/Lang/LanguageManager.cs
@@ -5,6 +5,7 @@
 using System.Resources;
 using Drachenhorn.Xml;
 using Easy.Logger.Interfaces;
+using GalaSoft.MvvmLight;
 using GalaSoft.MvvmLight.Ioc;
 
 namespace Drachenhorn.Core.Lang
@@ -13,7 +14,7 @@ public class LanguageManager : BindableBase, INotifyLanguageChanged
     {
         #region Properties
 
-        private readonly ResourceManager _resourceManager =
+        private readonly ResourceManager _resourceManager = 
             new ResourceManager("Drachenhorn.Core.Lang.lang", typeof(LanguageManager).Assembly);
 
         private CultureInfo _currentCulture = CultureInfo.CurrentUICulture;
@@ -47,6 +48,9 @@ public CultureInfo CurrentCulture
         /// <returns>Translated Text.</returns>
         public string GetLanguageText(string identifier)
         {
+            if (ViewModelBase.IsInDesignModeStatic)
+                return identifier;
+
             try
             {
                 return _resourceManager.GetString(identifier, CurrentCulture)?.Replace("\\n", "\n");
diff --git a/Drachenhorn.Core/Settings/ISettings.cs b/Drachenhorn.Core/Settings/ISettings.cs
index 6830c2b..61b9cc5 100644
--- a/Drachenhorn.Core/Settings/ISettings.cs
+++ b/Drachenhorn.Core/Settings/ISettings.cs
@@ -12,8 +12,7 @@ public interface ISettings : INotifyPropertyChanged
 
         CultureInfo CurrentCulture { get; set; }
         string Version { get; }
-        string GitCommit { get; }
-        string GitCommitLink { get; }
+        string NewVersion { get; }
 
         VisualThemeType VisualTheme { get; set; }
         string AccentColor { get; set; }
diff --git a/Drachenhorn.Desktop/Converter/NullVisibilityConverter.cs b/Drachenhorn.Desktop/Converter/NullVisibilityConverter.cs
index ce8e8ff..189dad1 100644
--- a/Drachenhorn.Desktop/Converter/NullVisibilityConverter.cs
+++ b/Drachenhorn.Desktop/Converter/NullVisibilityConverter.cs
@@ -14,10 +14,19 @@ public class NullVisibilityConverter : IValueConverter
         /// <inheritdoc />
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
         {
-            if (value == null)
-                return Visibility.Collapsed;
-            else
-                return Visibility.Visible;
+            var onNull = Visibility.Collapsed;
+            var notNull = Visibility.Visible;
+
+            if (parameter != null && parameter.ToString() == "Invert")
+            {
+                onNull = Visibility.Visible;
+                notNull = Visibility.Collapsed;
+            }
+
+            if (value == null || string.IsNullOrEmpty(value.ToString()))
+                return onNull;
+
+            return notNull;
         }
 
         /// <inheritdoc />
diff --git a/Drachenhorn.Desktop/Drachenhorn.Desktop.csproj b/Drachenhorn.Desktop/Drachenhorn.Desktop.csproj
index d7f353c..9ad2f37 100644
--- a/Drachenhorn.Desktop/Drachenhorn.Desktop.csproj
+++ b/Drachenhorn.Desktop/Drachenhorn.Desktop.csproj
@@ -469,9 +469,6 @@
     <Resource Include="..\img\White\Common\Yes.png">
       <Link>Images\White\Common\Yes.png</Link>
     </Resource>
-    <Content Include="commit">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </Content>
     <Resource Include="Images\Common\Drachenhorn.ico" />
     <Content Include="log4net.config">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
diff --git a/Drachenhorn.Desktop/UI/Lang/TranslateExtension.cs b/Drachenhorn.Desktop/UI/Lang/TranslateExtension.cs
index 3adbe64..3388897 100644
--- a/Drachenhorn.Desktop/UI/Lang/TranslateExtension.cs
+++ b/Drachenhorn.Desktop/UI/Lang/TranslateExtension.cs
@@ -20,7 +20,7 @@ public TranslateExtension(string name) : base("[%" + name + "]")
             try
             {
                 if (ViewModelBase.IsInDesignModeStatic)
-                    Source = new LanguageManager {CurrentCulture = CultureInfo.CurrentCulture};
+                    Source = new LanguageManager();
                 else
                     Source = SimpleIoc.Default.GetInstance<LanguageManager>();
             }
diff --git a/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml b/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml
index 22de217..9ca3400 100644
--- a/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml
+++ b/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml
@@ -92,51 +92,45 @@
         <mah:MetroTabItem Header="{lang:Translate UI.Properties.About}"
                           CloseButtonEnabled="False">
             <StackPanel>
-                <Border Margin="5" BorderThickness="2">
-                    <Grid>
-                        <Grid.ColumnDefinitions>
-                            <ColumnDefinition Width="Auto" />
-                            <ColumnDefinition Width="*" />
-                        </Grid.ColumnDefinitions>
-                        <Grid.RowDefinitions>
-                            <RowDefinition Height="Auto" />
-                            <RowDefinition Height="Auto" />
-                            <RowDefinition Height="Auto" />
-                            <RowDefinition Height="Auto" />
-                        </Grid.RowDefinitions>
-                        <TextBlock Text="{lang:Translate About.Version}"
-                                   Grid.Row="0" Grid.Column="0" Margin="5" />
-                        <TextBlock Text="{Binding Settings.Version}"
-                                   Grid.Row="0" Grid.Column="1" Margin="5" />
-
-                        <TextBlock Text="{lang:Translate About.GitCommit}" Grid.Row="1" Grid.Column="0"
-                                   Margin="5" />
-                        <TextBlock Margin="5" Grid.Row="1" Grid.Column="1">
-                            <Hyperlink NavigateUri="{Binding Settings.GitCommitLink}"
-                                       RequestNavigate="Hyperlink_RequestNavigate">
-                                <Run Text="{Binding Settings.GitCommit, FallbackValue=commit, Mode=OneWay}" />
-                            </Hyperlink>
-                        </TextBlock>
+                <Border Margin="5" BorderThickness="2" BorderBrush="{DynamicResource ControlBorderBrush}">
+                    <StackPanel>
+
+                        <DockPanel Margin="10">
+                            <mah:ProgressRing Name="UpdateRing" IsActive="False" Height="55" Width="55"
+                                              Foreground="{DynamicResource AccentColorBrush}" DockPanel.Dock="Right"/>
+
+                            <TextBlock Margin="5 3 5 0" DockPanel.Dock="Bottom" FontSize="12">
+                                <Hyperlink NavigateUri="https://github.com/lightlike"
+                                           RequestNavigate="Hyperlink_RequestNavigate">
+                                    <Run Text="lightlike (DanielN)" />
+                                </Hyperlink>
+                            </TextBlock>
+
+                            <StackPanel Orientation="Horizontal">
+                                <TextBlock Text="Drachenhorn" FontSize="30" Margin="0 0 10 0" FontFamily="{StaticResource Morpheus}"/>
+                                <TextBlock Text="v" FontSize="20" FontFamily="{StaticResource Morpheus}" VerticalAlignment="Bottom"/>
+                                <TextBlock Text="{Binding Settings.Version}" FontSize="20" FontFamily="{StaticResource Morpheus}" VerticalAlignment="Bottom"/>
+                            </StackPanel>
+                        </DockPanel>
+
+                        <WrapPanel Margin="20 5 10 0" Visibility="{Binding Settings.NewVersion, Converter={StaticResource NullVisibilityConverter}}">
+                            <TextBlock Text="{lang:Translate Updater.UpdateAvailable}" FontSize="18"/>
+                            <TextBlock Text="{Binding Settings.NewVersion}" FontSize="18"/>
+                        </WrapPanel>
 
-                        <WrapPanel Grid.Row="2" Grid.Column="0" Grid.ColumnSpan="2" Margin="5">
-                            <Button Content="{lang:Translate Updater.CheckForUpdate}" HorizontalAlignment="Left"
-                                    Click="UpdateButton_OnClick" />
+                        <Button Content="{lang:Translate Updater.CheckForUpdate}"
+                                Click="CheckUpdateButton_OnClick" HorizontalAlignment="Right"
+                                Visibility="{Binding Settings.NewVersion, Converter={StaticResource NullVisibilityConverter}, ConverterParameter=Invert}"/>
 
-                            <mah:ProgressRing Name="UpdateRing" IsActive="False" Height="28" Width="28" />
+                        <WrapPanel HorizontalAlignment="Right" Margin="10 5 10 0"
+                                   Visibility="{Binding Settings.NewVersion, Converter={StaticResource NullVisibilityConverter}}">
+                            <Button Content="{lang:Translate Updater.DoUpdate}"/>
+                            <Button Content="{lang:Translate Updater.Changelog}"/>
                         </WrapPanel>
-
-                        <TextBlock Text="{lang:Translate About.Publisher}" Grid.Row="3" Grid.Column="0"
-                                   Margin="5" />
-                        <TextBlock Margin="5" Grid.Row="3" Grid.Column="1">
-                            <Hyperlink NavigateUri="https://github.com/lightlike"
-                                       RequestNavigate="Hyperlink_RequestNavigate">
-                                <Run Text="lightlike (DanielN)" />
-                            </Hyperlink>
-                        </TextBlock>
-                    </Grid>
+                    </StackPanel>
                 </Border>
 
-                <Border Margin="5" BorderThickness="2">
+                <Border Margin="5" BorderThickness="2" BorderBrush="{DynamicResource ControlBorderBrush}">
                     <Grid>
                         <Grid.ColumnDefinitions>
                             <ColumnDefinition Width="Auto" />
diff --git a/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml.cs b/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml.cs
index 738b56b..56f953f 100644
--- a/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml.cs
+++ b/Drachenhorn.Desktop/UserControls/Common/SettingsViewControl.xaml.cs
@@ -54,7 +54,7 @@ private void LanguageComboBox_SelectionChanged(object sender, SelectionChangedEv
             }
         }
 
-        private void UpdateButton_OnClick(object sender, RoutedEventArgs e)
+        private void CheckUpdateButton_OnClick(object sender, RoutedEventArgs e)
         {
             UpdateRing.IsActive = true;
 
diff --git a/Drachenhorn.Desktop/UserSettings/Settings.cs b/Drachenhorn.Desktop/UserSettings/Settings.cs
index 9c7fc71..b5110dc 100644
--- a/Drachenhorn.Desktop/UserSettings/Settings.cs
+++ b/Drachenhorn.Desktop/UserSettings/Settings.cs
@@ -23,13 +23,6 @@ public class Settings : BindableBase, ISettings
 
         public Settings()
         {
-            var path = Path.Combine(Environment.CurrentDirectory, "commit");
-            if (File.Exists(path))
-                GitCommit = File.ReadAllText(Path.Combine(Environment.CurrentDirectory, "commit")).Replace("\r", "")
-                    .Replace("\n", "");
-            else
-                GitCommit = "No Commit found";
-
             PropertyChanged += (sender, args) => { Save(); };
         }
 
@@ -41,8 +34,6 @@ public Settings()
 
         [XmlIgnore] private SheetTemplate _currentTemplate;
 
-        [XmlIgnore] private string _gitCommit;
-
         [XmlIgnore] private bool _isNew = true;
 
         [XmlIgnore] private VisualThemeType _visualTheme;
@@ -117,28 +108,7 @@ public CultureInfo CurrentCulture
         public string Version => SquirrelManager.CurrentVersion;
 
         [XmlIgnore]
-        public string GitCommit
-        {
-            get => _gitCommit;
-            private set
-            {
-                if (_gitCommit == value)
-                    return;
-                _gitCommit = value;
-                OnPropertyChanged();
-            }
-        }
-
-        [XmlIgnore]
-        public string GitCommitLink
-        {
-            get
-            {
-                if (GitCommit.Contains(" "))
-                    return null;
-                return @"https://github.com/lightlike/Drachenhorn/commit/" + GitCommit;
-            }
-        }
+        public string NewVersion => SquirrelManager.NewVersion;
 
         [XmlElement("VisualTheme")]
         public VisualThemeType VisualTheme
diff --git a/Drachenhorn.Desktop/UserSettings/SquirrelManager.cs b/Drachenhorn.Desktop/UserSettings/SquirrelManager.cs
index 8525765..cedb6d0 100644
--- a/Drachenhorn.Desktop/UserSettings/SquirrelManager.cs
+++ b/Drachenhorn.Desktop/UserSettings/SquirrelManager.cs
@@ -33,6 +33,8 @@ private set
                 _newVersion = value;
             }
         }
+
+
         private static string _currentVersion;
 
         public static string CurrentVersion
@@ -43,18 +45,18 @@ public static string CurrentVersion
                 {
                     try
                     {
-                        using (var mgr = new UpdateManager(null))
+                        using (var mgr = new UpdateManager("C:"))
                         {
                             _currentVersion = mgr.CurrentlyInstalledVersion().ToString();
                         }
                     }
                     catch (Exception e)
                     {
+                        _currentVersion = "X.X.X";
+
                         SimpleIoc.Default.GetInstance<ILogService>().GetLogger<Settings>()
                             .Debug("Unable to load Squirrel Version.", e);
                     }
-
-                    _currentVersion = "Application not installed.";
                 }
 
                 return _currentVersion;
diff --git a/Drachenhorn.Desktop/commit b/Drachenhorn.Desktop/commit
deleted file mode 100644
index 21bf4de..0000000
--- a/Drachenhorn.Desktop/commit
+++ /dev/null
@@ -1 +0,0 @@
-Application not published
\ No newline at end of file