Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous behaviour of blacklist flag #8

Open
alfuken opened this issue Jan 14, 2020 · 4 comments
Open

Ambiguous behaviour of blacklist flag #8

alfuken opened this issue Jan 14, 2020 · 4 comments

Comments

@alfuken
Copy link

alfuken commented Jan 14, 2020

On lines https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L212 and https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L216 it behaves as expected, but here https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L222 and here https://github.com/DoctorFTB/LagBGonReborn/blob/master/src/main/java/ftblag/lagbgonreborn/LBGCommand.java#L226 it's completely opposite. This way if blacklist is true, items are being removed, but the entities list turns into a whitelist, thus removing ALL entities EXCEPT blacklisted.

Please make the entities removal behave as intended. Thanks!

@DoctorFTB
Copy link
Owner

Try 1.0.7 version.

@Fatetaker-voidwalker
Copy link

Having items on the blacklist in version 1.0.8 does not prevent removal...

# Should we use a blacklist or a whitelist for mob removal? \n Blacklist is default.
B:Blacklist=true

# List of Entities not to destroy.
S:EntityBlackList <
    minecraft:cow
    dragonskull
    doggytalents:dog
    openblocks:hang_glider
    randomthings:goldenchicken
    iceandfire:dragonskull
    chococraft:chocobo
    minecraft:item_frame
    minecraft:armor_stand
    minecraft:villager
    minecraft:chicken
 >

@PiggiesGoSqueal
Copy link

Can confirm this is an issue on the 1.0.8 version.
/bgon clear will wipe all mobs including those in my blacklist.

I also tested on the 1.0.7 version for the same result.

Forge 1.12.2 v2854
Bgon Version: 1.0.7 & 1.0.8
latest.log: https://gist.github.com/pinkpig3777/ab200e0ea6b8387fa4db09205c41831e
debug.log: https://gist.github.com/pinkpig3777/f50bd8ef9312a622ccd8f3067b6fab7d

    # List of Entities not to destroy.
    S:EntityBlackList <
        minecraft:chicken
        minecraft:pig
        minecraft:cow
        minecraft:sheep
        minecraft:rabbit
        minecraft:horse
        minecraft:llama
        minecraft:donkey
        minecraft:mule
        minecraft:endermite
     >

@PiggiesGoSqueal
Copy link

PiggiesGoSqueal commented May 25, 2020

Temporary Solution:
Using v1.0.8 you can set the blacklist option to:
B:Blacklist=false
and this will ENABLE the blacklist, even though it says it is disabling it.

I just tested it and my pigs and endermites will stay while zombies are cleared. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants