Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable plugin execution order #930

Open
Difegue opened this issue Dec 16, 2023 · 3 comments
Open

Customizable plugin execution order #930

Difegue opened this issue Dec 16, 2023 · 3 comments

Comments

@Difegue
Copy link
Owner

Difegue commented Dec 16, 2023

This is a follow-up to #789 -- A generic title update setting leads to conflicts if you have multiple plugins enabled and can't decide which order they're ran in.

It might also be good to be able to block a plugin from updating archive titles even if the generic setting is toggled on, or move the generic setting to a per-plugin option again(but handled server-side).. god this is complicated

@khaaansolo
Copy link

I've noticed on the latest version of LRR 0.9.0, you can no longer have eze (or any metadata plugin that attempts to rename) turned ON with Filename Parsing turned ON and get the result of Parsed Name + Metadata tags only. Instead, it looks like File Name Parsing runs, does its job and then immediately gets its archive title replaced by eze archive title.

Annoyingly, the only way I've found around this is to turn on Filename Parsing only as the sole metadata plugin that runs on queue. Once the files are put in with only the Parsed Name, then go to Metadata plugin, TURN OFF 'allow plugins to replace archive titles'. Then go to Batch Operations and run eze. Now eze will place in all the tag info but leave the archive title alone.

@nuclear06
Copy link
Contributor

How about adding a field in Redis to store YAML, and using YAML to configure plugins behavior?
But I'm concerned that this add unnecessary complexity.

# config.yaml
plugins:
  - Ehentai   # use all info  

  - regexPlugin1    # preprocess title
  - titleOrginPlugin
    exclude: 
      - tags
  - regexPlugin2    # postprocess title

  - nHentai   # only use tags
    exclude: 
      - title

@Difegue
Copy link
Owner Author

Difegue commented Jul 28, 2024

no -- I don't think the database should store arbitrary data structures instead of using existing redis constructs like hash/sets/etc.
Tag rules are about as far as I'm willing to push it.

Although I like the idea of adding "exclude" fields for each plugin to either block tag or title updates -- There's probably a good UI concept in there that could exist.

Ideally we'd replace the current on/off toggles in plugin configuration with a list you'd drop plugins in the desired autoexec order, with checkboxes to include tags/title for each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants