New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate new device factory and its use for I22 #878

Closed

callumforrester opened this issue Oct 31, 2024 · 0 comments · Fixed by #881

Labels

bug python

Contributor

callumforrester commented Oct 31, 2024

From @DominicOram, the plan:

Reinstate new device factory and it's use for i22

In the short term leave inject as it is i.e. currently broken (we can work around this by just specifying the device name in GDA anyway)

Fix any outstanding issues with the new factory found from i22 testing

Move all beamlines to the new factory

Come up with the best way to fix inject, as discussed on the linked issue

This issue covers the first and third points

Acceptance Criteria

Isolated device factory #841 (reverted in Revert device_factory changes #869) is restored
Discussion: Architecture for inject #874, Prevent simulated connect from trying to connect to real devices on i22 #849 and Prevent devices connecting as side effect of use elsewhere #860 are not present and there are tests to verify this

callumforrester mentioned this issue

Reinstate DeviceInitializationController #881

Merged

4 tasks

stan-dot added bug python labels

DiamondJoseph closed this as completed in #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment