Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dodal connect --all is broken #875

Open
DominicOram opened this issue Oct 30, 2024 · 2 comments · May be fixed by #877
Open

Dodal connect --all is broken #875

DominicOram opened this issue Oct 30, 2024 · 2 comments · May be fixed by #877
Assignees
@rtuck99

Comments

@DominicOram
Copy link
Contributor

When I run dodal connect --help I am told I should be able to run dodal connect --all to try and connect to all known beamlines. However, when I try this I get Error: Missing argument '{i04|i24|b01_1|s03|i03|i04-1|i04_1|i13-1|i13_1|i20-1|i20_1|i23|p99|p49|p46|training_rig|p48|p47|i22|p38|p45}'.

Acceptance Criteria

  • dodal connect --all and dodal connect -a work as expected
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Oct 30, 2024
@DominicOram DominicOram mentioned this issue Oct 30, 2024
Merged
4 tasks
@rtuck99
Copy link
Contributor

rtuck99 commented Oct 31, 2024

dodal connect --all isn't actually intended to connect to all beamlines. Instead it connects to devices in the named beamline that are ordinarily skipped due to decorators.

@rtuck99 rtuck99 linked a pull request Oct 31, 2024 that will close this issue
Open
4 tasks
@DominicOram
Copy link
Contributor Author

My bad, I still think this is useful though, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement dodal connect ALL to test connection to all beamlines DiamondLightSource/dodal
2 participants
@rtuck99 @DominicOram