Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Config to use Pydantic BaseSettings #699

Open
stan-dot opened this issue Nov 5, 2024 · 2 comments
Open

Refactor Config to use Pydantic BaseSettings #699

stan-dot opened this issue Nov 5, 2024 · 2 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code

Comments

@stan-dot
Copy link
Contributor

stan-dot commented Nov 5, 2024

based on the discussion in #495 this refactor would make the config more standard
#649 (comment)
@stan-dot stan-dot added enhancement New feature or request dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 5, 2024
@stan-dot
Copy link
Contributor Author

stan-dot commented Nov 5, 2024 •
edited
Loading

field priorities suggested by Pydantic are - https://docs.pydantic.dev/latest/concepts/pydantic_settings/#field-value-priority

we can customize this if we'd like to a different setup

#495 (comment)

@stan-dot stan-dot linked a pull request Nov 5, 2024 that will close this issue
Make Settings Pydantic and use the power of BaseSettings to simplify CLI #700
Closed
@callumforrester callumforrester changed the title Refactor Settings to Pydantic Refactor Config to use Pydantic BaseSettings Nov 6, 2024
@callumforrester
Copy link
Contributor

I made the title slightly clearer, but yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Settings Pydantic and use the power of BaseSettings to simplify CLI DiamondLightSource/blueapi
2 participants
@callumforrester @stan-dot