feat: api 기초 구현 & 환경변수 및 스플래시 화면 설정 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw-lim
commented
Oct 3, 2024
There was a problem hiding this comment.
auth instance 관련 커스텀 훅입니다. 추후에 토큰 관리 방식에 따라서 수정이 필요합니다!
There was a problem hiding this comment.
일반 instance와 auth instance로 분리해두었습니다
wjddnjs7895
reviewed
Oct 4, 2024
There was a problem hiding this comment.
혹시 png말고 svg로도 가능한가요? 나중에 확장성 고려해서 svg로 해두는것도 가능하다면 좋을 것 같아서요!
너무 많이 바꾸셔야하면 무시하셔도 됩니다
There was a problem hiding this comment.
앗 그럼 일단 png로 해두겠습니다,,
wjddnjs7895
reviewed
Oct 4, 2024
There was a problem hiding this comment.
splash screen 으로 1s는 약간 짧지 않을까요?
There was a problem hiding this comment.
스플래시 스크린은 이후에 토큰을 확인하는 시간 동안 띄워둬여할 것 같아 나중에 토큰 로직 합쳐지면 수정해보겠습니다!
wjddnjs7895
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
📷 스크린샷
🎸 기타
FAILURE: Build failed with an exception. in "react-native": "0.75.2", crazycodeboy/react-native-splash-screen#649