Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affectedProjects tab false negatives on API error #1080

Open
2 tasks done
valentijnscholten opened this issue Nov 8, 2024 · 1 comment
Open
2 tasks done

affectedProjects tab false negatives on API error #1080

valentijnscholten opened this issue Nov 8, 2024 · 1 comment
Labels
defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort

Comments

@valentijnscholten
Copy link
Contributor

Current Behavior

https://deptrack.com/vulnerabilities/GITHUB/GHSA-x8vp-gf4q-mw5j/affectedProjects

Which performs a request to

https://deptrack.com/api/v1/vulnerability/source/GITHUB/vuln/GHSA-x8vp-gf4q-mw5j/projects?excludeInactive=true&searchText=

When the API returns a (500) error upon retrieving the affectedProjects for a Vulnerability, there is no indication of the error and the affectedProjects tab remains empty (0).

Image

Steps to Reproduce

This only happens when the API returns an error, in my case it was cause by 1 or more projects having the ACTIVE column set to NULL.

Expected Behavior

Some feedback about the error.

Dependency-Track Frontend Version

4.12.1

Browser

Google Chrome

Browser Version

latest

Operating System

Windows

Checklist

@valentijnscholten valentijnscholten added defect Something isn't working in triage labels Nov 8, 2024
@nscuro nscuro added p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort and removed in triage labels Nov 19, 2024
@nscuro
Copy link
Member

nscuro commented Nov 19, 2024

Hmmm I think the bootstrap-table component doesn't propagate errors to the parent Vue context (... what am I even saying?).

In other words I believe we need to explicitly register an onLoadError handler for all tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort
Projects
None yet
Development

No branches or pull requests

2 participants