Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #3

Open
DenverCoder1 opened this issue Oct 6, 2020 · 6 comments
Open

Code cleanup #3

DenverCoder1 opened this issue Oct 6, 2020 · 6 comments
Labels

Comments

@DenverCoder1
Copy link
Owner

Can the code be cleaned up to be easier to read and more easily maintainable without removing any functionality?

@Claw-Hammer
Copy link
Contributor

Yes, i'll try to clean up your index

@MeetMangukiya7
Copy link

i would love to do this.

@hareesh-pillai
Copy link
Contributor

Hi @DenverCoder1

As part of this ticket, I think it would be a good idea to

  1. reorganise the folder structure - i.e create separate js, css and library folders and move the countdown.js, countdownStyle.css and dayjs.min.js files into them?
  2. move the JS code in the index file to the countdown.js file?

What are your thoughts?

@DenverCoder1
Copy link
Owner Author

@hareesh-pillai That would be great, it would definitely be a good improvement!

One thing that makes moving the JS out of the index file a bit difficult is that some PHP is inserted into the script at some points. Of course, there are ways to avoid that, though, and I still think it would be great for it to be done.

@avinashchandan12
Copy link

yes i am up for this

@DenverCoder1
Copy link
Owner Author

Hi @avinashchandan12, that would be great!

In just a few more hours it can count for Hacktoberfest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants