Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEC-16683] Decouple Agentless Scanning from CSPM #153

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

k3nz0
Copy link
Member

@k3nz0 k3nz0 commented Oct 30, 2024

What does this PR do?

Agentless Scanning does not require CSPM to be enabled to work correctly.
However, Agentless Scanning does require the AWS SecurityAudit policy to be installed.

In this PR we:

  • Decouple Agentless Scanning from CSPM (Cloud Security Posture Management)
  • Add a rule to check that resource collection is enabled when at least one Agentless Scanning option is enabled

@ktmq
Copy link
Contributor

ktmq commented Oct 31, 2024

please bump the version number in aws_quickstart/version.txt

Copy link
Contributor

@jvanbrie jvanbrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We merged a pretty big change to these files, so you'll need to merge those changes in and refactor a bit. We now default to adding the SecurityAudit Policy.

@k3nz0 k3nz0 force-pushed the moez.ezzeddine/decouple-cspm-agentless branch from 1690500 to 04a8cac Compare November 13, 2024 17:33
@k3nz0
Copy link
Member Author

k3nz0 commented Nov 14, 2024

Rebased and applied necessary changes to decouple Agentless from CSPM

@k3nz0 k3nz0 requested a review from jvanbrie November 14, 2024 11:52
Copy link
Contributor

@jvanbrie jvanbrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you up the version in version.txt?

@k3nz0
Copy link
Member Author

k3nz0 commented Nov 14, 2024

Taskcat tests are passing:

image

@k3nz0 k3nz0 force-pushed the moez.ezzeddine/decouple-cspm-agentless branch from 4682205 to 77558e8 Compare November 14, 2024 17:34
@k3nz0 k3nz0 merged commit a5a8d27 into master Nov 15, 2024
2 checks passed
@k3nz0 k3nz0 deleted the moez.ezzeddine/decouple-cspm-agentless branch November 15, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants