Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat Exchanger Connectors #177

Open
RaphaelGebhart opened this issue Mar 15, 2024 · 0 comments
Open

Heat Exchanger Connectors #177

RaphaelGebhart opened this issue Mar 15, 2024 · 0 comments

Comments

@RaphaelGebhart
Copy link
Contributor

Currently Open Modelica cant display cross flow heat exchangers inlets/outlets correctly (ThermofluidStream.HeatExchangers.CrossFlowNTU, ThermofluidStream.HeatExchangers.DiscretizedCrossFlowHEX, ThermofluidStream.HeatExchangers.DiscretizedCrossFlowHEX_FR), since the annotation rotation=if crossFlow then -90 for inlets/outlets seems to be ignored by Open Modelica.

Furthermore the implementation causes difficulties when connecting components to the cross flow heat exchangers (the connection lines are a mess) (At least for Dymola 2022x, it seems to work well with 2024x tho).

Therefor we might consider moving the inlets/outlets from the base classes ThermofluidStream.HeatExchangers.Internal.PartialNTU, ThermofluidStream.HeatExchangers.Internal.PartialDiscretizedHEX, ThermofluidStream.Undirected.HeatExchangers.Internal.PartialDiscretizedHEX to the inheriting models and use internal variables at the base models instead. This approach would also make it more simple to add other Heat Exchanger Configurations like Parallel Flow Heat Exchangers, because the if else crossFlow, parallelFlow, counterFlow = false, true is rather impractical i assume.

I already fixed this issue in #167, but restored the old version, since the regression test Validation fails. I assume its only a change in variable name, but still, i would rather use an independet issue for changing HEX connectors, since #167 already contains a lot of changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant