Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid connectors between MSL and TFS #125

Open
hubertblervaque opened this issue May 17, 2023 · 5 comments
Open

Fluid connectors between MSL and TFS #125

hubertblervaque opened this issue May 17, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@hubertblervaque
Copy link

I am trying to build a plug between the MSL fluid ports and the TFS fluid connectors (inlet, outlet and undirected). I developped two approaches: by assembly of "boundary" components or by a system of equations. In both cases, I have difficulty to have a robustess plug working for all the unit tests I defined.
Is there a fundamental conflict between MSL and TFS approaches that makes it impossible to create a plug between the two fluid connectors?
Has anyone ever built such a plug (for instance for other library)?

@dzimmer
Copy link
Contributor

dzimmer commented May 23, 2023

The fundamental approach between TFS and MSL is indeed different. It is best to read the suggested literature to fully understand this. TFS interface is created such that no large non-linear equation systems shall spread across components if used properly.
Developing an interface is not impossible though but needs to be done with care. In any case the interface makes only sense to connect different sub-systems not on the component level.
We are currently developing and testing such an interface. When it is ready we will make it part of the TFS Library.

@hubertblervaque
Copy link
Author

Dear Dr Zimmer, thank you for your answer. It was a pleasure to read the literature about ThermoFluidStream, especially because the concept of inertial pressure is far from common.
I spent a couple of days on developing and testing my "working in some cases" plug. It would a pleasure to take part in the development of your solution. Feel free, you or a member of your team, to contact me at hbe@modeliconseil.com to see whether my contribution could be useful.

@dzimmer
Copy link
Contributor

dzimmer commented May 24, 2023

Everyone is welcome to contribute. Feel free to offer a link to a fork or raise a merge request. We can then review and decide. Also test cases can be of interest to us. Simply keep in mind that we need to have our own internal schedule.

@FrancNep
Copy link

Hi,

I think that the best way is to develop a model of Volume (based on MSL or TFS Volume ) integrating both bi-directional interfaces from the MSL and TFS library. It's simple, robust and performance.

Best regards,

@nieweber
Copy link
Contributor

Hey,

thank you for your suggestion!

Indeed that is also the way we are internally developing an adapter between TFS and MSL. We are still conducting some performance tests and are working on a guideline for the modeler as the initialization of the volume and and the mass-flows on MSL and TFS side need to be appropriate in edge cases for very small volumes.

If you did some tests on your own, it would be great to have a look!

Best regards
Niels

@nieweber nieweber self-assigned this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants