Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the L-Algorithm #1744

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Implementation of the L-Algorithm #1744

merged 10 commits into from
Oct 9, 2024

Conversation

troussil
Copy link
Member

@troussil troussil commented Sep 19, 2024

PR Description

Implementation of the L-Algorithm. We've followed the design of previous versions of plane-probing algorithms. We've generalized several existing methods (e.g. closestPointInList, relativePoint, aboslutePoint) to make them work with slightly different data structures needed in our implementation of the L-Algorithm.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@troussil troussil self-assigned this Sep 19, 2024
@dcoeurjo
Copy link
Member

dcoeurjo commented Oct 2, 2024

/builddoc

Copy link

github-actions bot commented Oct 2, 2024

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1744/index.html

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just minor comments

@troussil
Copy link
Member Author

troussil commented Oct 8, 2024

@dcoeurjo should be fine now

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merging

@dcoeurjo dcoeurjo merged commit 2c16fe8 into DGtal-team:master Oct 9, 2024
10 checks passed
@dcoeurjo dcoeurjo deleted the LAlg branch October 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants