Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added storybook ui components #434

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Ishaan28malik
Copy link
Contributor

UI storybook added for missing and new components

Copy link

changeset-bot bot commented Apr 6, 2024

🦋 Changeset detected

Latest commit: 10b7e3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cypherock/cysync-ui Patch
@cypherock/cysync-desktop Patch
@cypherock/cysync-core Patch
@cypherock/cysync-desktop-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/ui/src/stories/atoms/Chip.stories.tsx Outdated Show resolved Hide resolved
packages/ui/src/stories/atoms/Container.stories.tsx Outdated Show resolved Hide resolved
packages/ui/src/stories/atoms/Divider.stories.tsx Outdated Show resolved Hide resolved
Comment on lines 36 to 47
lock: () => {
console.log('Lock action');
},
toggleDiscreetMode: () => {
console.log('Toggling discreet mode');
},
onNotificationClick: () => {
console.log('Notification clicked');
},
onSyncClick: () => {
console.log('Sync clicked');
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI does not look good.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't done from my end @irshadCypherock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 14 to 21
export const Default: Story = {
args: {
overrideDecimal: undefined,
error: undefined,
value: 2,
captions: [],
},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slider does not work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 14 to 16
export const Default: Story = {
args: {},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass required props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 14 to 19
export const Default: Story = {
args: {
text: 'Placeholder',
value: true,
},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass required props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +14 to +20
export const Default: Story = {
args: {
margin: undefined,
leftComponent: undefined,
rightComponent: undefined,
},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This displays empty component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is appearing
image


export const Default: Story = {
args: {
value: '10',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing argument: postfixText

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Comment on lines 13 to 21
let address = 'Noida, Delhi';
export const Default: Story = {
args: {
value: address,
onChange: newAddress => {
address = newAddress;
},
},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot change input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines 13 to 22
let toggleValue = true;
export const Default: Story = {
args: {
text: 'Placeholder',
value: toggleValue,
onChange: newToggleValue => {
toggleValue = newToggleValue;
},
},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggle does not work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants