Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing name of LicenseChoice class #307

Open
sschuberth opened this issue Jun 23, 2023 · 0 comments
Open

Confusing name of LicenseChoice class #307

sschuberth opened this issue Jun 23, 2023 · 0 comments

Comments

@sschuberth
Copy link
Contributor

I'm continuous stumbling over

To me, the name of the class sounds as if it would implement a choice mechanism that for example says "whenever you encounter the SPDX license expression MIT OR BSD, choose MIT". But actually, no "choice" seems to be involved here at all, and the class simply holds a list of license objects and / or its belonging SPDX license expression string.

So, where does "Choice" in the class name come from? Does it make sense to clarify this in the class docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant