Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request for Distortion Shader #75

Open
Ajido opened this issue Mar 27, 2024 · 1 comment
Open

Feature Request for Distortion Shader #75

Ajido opened this issue Mar 27, 2024 · 1 comment

Comments

@Ajido
Copy link

Ajido commented Mar 27, 2024

thank you for providing such an amazing shader. This is the best method for urp distortion.
i have added the following feature for my own use, but no idea about CustomEditor, so I haven't been able to make PR for it.. would it be possible to add these features?

  • Use Vertex Color Alpha as Distortion Intensity. For Color over Lifetime
// "mul" is preferable not "add"
half distortionIntensity = input.color.w * _DistortionIntensity
  • Distortion Base Map R/G Mul
distortion.x = distortionSrc[(uint)_BaseMapChannelsX] * _DistortionRMultiplier;
distortion.y = distortionSrc[(uint)_BaseMapChannelsY] * _DistortionGMultiplier;
  • Distortion Base Map UV Movement
baseMapUv.x += _Time.y * _DistortionUSpeed;
baseMapUv.y += _Time.y * _DistortionVSpeed;

unsure if these features would be beneficial for Nova Shader. maybe i should fork. thoughts?

@CA-Tatami
Copy link
Contributor

@Ajido
Thank you for using our services and for contacting us.
As this is a request for additional functionality, we will discuss with our development team on the details to be addressed.
It is expected to take some time, so we will contact you again when we have decided on a course of action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants