Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape strings in endpoint paths #159

Open
Naapperas opened this issue Jul 27, 2023 · 1 comment
Open

Escape strings in endpoint paths #159

Naapperas opened this issue Jul 27, 2023 · 1 comment

Comments

@Naapperas
Copy link
Contributor

While looking at the source code for recordings, I noticed that key ids(which are the recording names) are being placed directly on endpoint URLs without being escaped. This can cause errors when, for example, the recording name is itself a file path: this would lead to an HTTP call to /recordings/live/something/else/name, which is obviously wrong.

@Ulexus
Copy link
Member

Ulexus commented Nov 10, 2023

Definitely sounds like a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants