Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background updated #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Raman01010010
Copy link

@Raman01010010 Raman01010010 commented Oct 8, 2023

Background Color

Description

Changed Background Color

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

Fixes # (issue)

Type of change

UI Changes for Sign Up page

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

The page was blank initially

How Has This Been Tested?

Simple UI element changed and reflected in page.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

Checklist:

  • I have registered myself at Contrihub website.
  • My code follows the code style of this project.
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Copy link
Collaborator

@admirerr admirerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raman01010010 What I can find is you have simply removed the old background. What you were supposed to do is to replace the old gradient background with a new one which would make the page more attractive than it was before.

@Raman01010010
Copy link
Author

@Raman01010010 What I can find is you have simply removed the old background. What you were supposed to do is to replace the old gradient background with a new one which would make the page more attractive than it was before.
Now i have updated it to dynamic background

@admirerr
Copy link
Collaborator

admirerr commented Oct 9, 2023

@Raman01010010 there's still some issue with your code. Try to cross check your code by running the code and attaching screenshot here.

@Raman01010010
Copy link
Author

@Raman01010010 there's still some issue with your code. Try to cross check your code by running the code and attaching screenshot here.
Screenshot (657)
i have added two packages "react-particles","tsparticles-slim" try reinstalling them

@admirerr
Copy link
Collaborator

@Raman01010010 there's still some issue with your code. Try to cross check your code by running the code and attaching screenshot here.
Screenshot (657)
i have added two packages "react-particles","tsparticles-slim" try reinstalling them

@Raman01010010 There's some conflict in merging the PR. Resolve the conflict and then update it here.

@Raman01010010
Copy link
Author

@Raman01010010 there's still some issue with your code. Try to cross check your code by running the code and attaching screenshot here.
Screenshot (657)
i have added two packages "react-particles","tsparticles-slim" try reinstalling them

@Raman01010010 There's some conflict in merging the PR. Resolve the conflict and then update it here.

sir please tell how can i resolve conflicts as its working on mine system and what i need to do

@admirerr
Copy link
Collaborator

@Raman01010010 there's still some issue with your code. Try to cross check your code by running the code and attaching screenshot here.
Screenshot (657)
i have added two packages "react-particles","tsparticles-slim" try reinstalling them

@Raman01010010 There's some conflict in merging the PR. Resolve the conflict and then update it here.

sir please tell how can i resolve conflicts as its working on mine system and what i need to do

@Raman01010010 This will help you to resolve the conflicts.

https://stackoverflow.com/questions/31863429/how-do-i-resolve-conflicts-with-git

@Raman01010010
Copy link
Author

@Raman01010010 there's still some issue with your code. Try to cross check your code by running the code and attaching screenshot here.
Screenshot (657)
i have added two packages "react-particles","tsparticles-slim" try reinstalling them

@Raman01010010 There's some conflict in merging the PR. Resolve the conflict and then update it here.

sir please tell how can i resolve conflicts as its working on mine system and what i need to do

@Raman01010010 This will help you to resolve the conflicts.

https://stackoverflow.com/questions/31863429/how-do-i-resolve-conflicts-with-git

not getting option for resolve conflict

@admirerr admirerr self-requested a review October 14, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants