Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary reloads #119

Open
deepak-bharti-deel opened this issue Oct 27, 2018 · 2 comments
Open

remove unnecessary reloads #119

deepak-bharti-deel opened this issue Oct 27, 2018 · 2 comments
Assignees
@deepak-bharti-deel
Labels
cool its fun easy hacktoberfest

Comments

@deepak-bharti-deel
Copy link
Member

deepak-bharti-deel commented Oct 27, 2018 •
edited
Loading

There are many requests where page reload can be avoided.
Like

  1. when clicking on close/open label of issues changes and page is reloaded while this reload can be avoided by using javascript to change open to close etc on GUI 😄
  2. on deleting prs/issues there is a page reload which can be avoided by hiding that object using javascript.

every page reload removal gets ~30 points 😄
create different prs for each such solution
@deepak-bharti-deel deepak-bharti-deel self-assigned this Oct 27, 2018
@jarvisdev jarvisdev mentioned this issue Oct 27, 2018
Merged
ashwini571 added a commit to ashwini571/ContriHub-18 that referenced this issue Oct 27, 2018
@ashwini571
ContriHUB#119 Page reloading on removing issue and PRs resolved
9e20c40
@jarvisdev jarvisdev mentioned this issue Oct 27, 2018
Closed
@deepak-bharti-deel
Copy link
Member Author

  1. Remove page reload when any mentor verify/reject a pr.
  2. Remove reloads on delete action on prs available at student/mentor profile.

@jarvisdev
Copy link
Contributor

jarvisdev commented Oct 27, 2018 •
edited
Loading

4 done already in PR #122
2 done in PR #129

ashwini571 added a commit to ashwini571/ContriHub-18 that referenced this issue Oct 28, 2018
@ashwini571
ContriHUB#119 Bug in reloading after removing issue from home page re…
5841e70 
…moved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak-bharti-deel deepak-bharti-deel

Labels
cool its fun easy hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deepak-bharti-deel @jarvisdev