cool#9992 doc electronic sign: fetch the created signature #10609
Conversation
but a local passes, retry. |
|
https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/2922/console again fails in:
but turns out my local baseline was newer when I ran cypress (vs the one I used for pushing), rebase. |
vmiklos
force-pushed
the
private/vmiklos/master
branch
from
362eaa8
to
efd3d15
Compare
|
https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04_cypress_desktop/2924/console still fails in:
hmm, let me try yesterday's baseline to see if that helps. |
Sign a hash with electronic signing, we get a postmessage that the signing is done on the external site, but we still don't have the signed hash. There is a /api/signatures/download-signed-file endpoint to fetch the PKCS#7 blob, but that is only meant to succeed once we know the signing happened. Handle this by fetching the signature once we got a postmessage that the signing was fine. The blob we get still needs integrating, though. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Id0dcdf5a6518c6b71ab02f1f77a3736038546821
vmiklos
force-pushed
the
private/vmiklos/master
branch
from
efd3d15
to
3689208
Compare
|
@caolanm could you please review this? Thanks. If the above cypress problem starts to be a pattern, we should probably investigate, but it's not something I see locally. Apart from that, only a last step is meant to be missing for the "have 1 working scenario" of this e-sign thing. |
Sign a hash with electronic signing, we get a postmessage that the
signing is done on the external site, but we still don't have the
signed hash.
There is a /api/signatures/download-signed-file endpoint to fetch the
PKCS#7 blob, but that is only meant to succeed once we know the signing
happened.
Handle this by fetching the signature once we got a postmessage that
the signing was fine.
The blob we get still needs integrating, though.
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: Id0dcdf5a6518c6b71ab02f1f77a3736038546821