Skip to content

Commit

Permalink
Remove label and replace svg with png images for notes and slide sorter
Browse files Browse the repository at this point in the history
- Remove label from notes and slide sorter button
- added svg and removed png for notes and slide sorter button
- adjusted image css for slide-action-buttons

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I05e79d91bd74f297b4d6ad1b3f304baf3a19d092
  • Loading branch information
Darshan-upadhyay1110 committed Nov 20, 2024
1 parent a151899 commit 943364f
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 21 deletions.
Binary file removed browser/images/presenterscreen-ButtonNotesNormal.png
Binary file not shown.
1 change: 1 addition & 0 deletions browser/images/presenterscreen-ButtonNotesNormal.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
1 change: 1 addition & 0 deletions browser/images/presenterscreen-ButtonSlideSorterNormal.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 2 additions & 21 deletions browser/src/slideshow/PresenterConsole.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,10 @@ class PresenterConsole {
</div>
<div id="action-buttons-container">
<button type="button" id="notes" disabled>
<img src="images/presenterscreen-ButtonNotesNormal.png">
<label>${labels[4]}</label>
<img src="images/presenterscreen-ButtonNotesNormal.svg">
</button>
<button type="button" id="slides" disabled>
<img src="images/presenterscreen-ButtonSlideSorterNormal.png">
<label>${labels[5]}</label>
<img src="images/presenterscreen-ButtonSlideSorterNormal.svg">
</button>
</div>
</div>
Expand Down Expand Up @@ -323,19 +321,8 @@ class PresenterConsole {

// Apply additional style for navigation button
navigationButtons.forEach((button) => {
button.style.width = '2.5vw';
button.style.height = '5.5vh';
button.style.border = 'none';
button.style.borderColor = this.slideShowColor;
button.style.justifyContent = 'center';
button.style.borderRadius = '50%';
// Select the image inside the button
const img = button.querySelector('img');
if (img) {
img.style.width = '100%'; // Scale image to fit within the button
img.style.height = '100%'; // Maintain aspect ratio
img.style.objectFit = 'cover'; // Maintain aspect ratio
}
});

// slideshow-control-container
Expand All @@ -345,12 +332,6 @@ class PresenterConsole {
actionBtnContainer.style.display = 'flex';
actionBtnContainer.style.gap = '1vw';

let slideActionImages = actionBtnContainer.querySelectorAll('button img');
slideActionImages.forEach((image) => {
image.style.height = '100%';
image.style.width = '100%';
});

this._first.addEventListener('click', L.bind(this._onToolbarClick, this));

let notesSeparator =
Expand Down

0 comments on commit 943364f

Please sign in to comment.