Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review PR on ink-examples #116

Open
arturoBeccar opened this issue Nov 2, 2023 · 2 comments
Open

Review PR on ink-examples #116

arturoBeccar opened this issue Nov 2, 2023 · 2 comments
Assignees
@tenuki

Comments

@arturoBeccar
Copy link
Member

arturoBeccar commented Nov 2, 2023 •
edited by tenuki
Loading

Review PR on ink-examples
use-ink/ink-examples#44 use-ink/ink-examples#52

This PR tests the changes implemented for workspaces in this other PR:
use-ink/cargo-contract#1358
@tenuki
Copy link
Collaborator

tenuki commented Nov 15, 2023

Nevertheless.. I do notice now there are changes mentioned here ( use-ink/cargo-contract#1358 ) that were meant to be tested and the contracts in the report doesn't .. I should give it a new review.. I guess.

@XianPaz
Copy link
Collaborator

XianPaz commented Nov 16, 2023

reviewed by @tenuki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenuki tenuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tenuki @XianPaz @arturoBeccar