Fixed Makefile to always include TOML files.

[EmbeddedDevops1]

PR Type

enhancement

---

Description

• Enhanced the Makefile to dynamically include all TOML files from the cover_agent/settings directory.
• Replaced hardcoded TOML file paths with a variable to improve maintainability and flexibility.

---

Changes walkthrough 📝

	Relevant files
Enhancement	Makefile Dynamically include all TOML files in Makefile                      Makefile Added a variable TOML_FILES to dynamically find and include all TOML files. Replaced hardcoded TOML file paths with the TOML_FILES variable in the installer target. +2/-7

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Path Validation The find command should verify that the cover_agent/settings directory exists to avoid silent failures if the directory is missing

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add validation to ensure required TOML configuration files are present before building the installer Add error handling to check if the find command returns any TOML files. If none are found, the build should fail with a clear error message since TOML files are required for the application to work. Makefile [3] -TOML_FILES=$(shell find cover_agent/settings -name "*.toml" | sed 's/.*/-\-add-data "&:."/' | tr '\n' ' ') +TOML_FILES=$(shell find cover_agent/settings -name "*.toml") +ifeq ($(strip $(TOML_FILES)),) + $(error No TOML files found in cover_agent/settings) +endif +TOML_FILES_ARGS=$(TOML_FILES:=:.) | sed 's/.*/-\-add-data "&"/' | tr '\n' ' ') Apply this suggestion Suggestion importance[1-10]: 8 Why: This is a critical validation that prevents silent failures. Without TOML files, the application would fail at runtime, so catching this during build time is important for reliability.	8
General	Improve shell command robustness by properly escaping special characters in file paths The sed command uses double quotes which could break if file paths contain special characters. Use single quotes to ensure paths with spaces or special characters are handled correctly. Makefile [3] -TOML_FILES=$(shell find cover_agent/settings -name "*.toml" | sed 's/.*/-\-add-data "&:."/' | tr '\n' ' ') +TOML_FILES=$(shell find cover_agent/settings -name "*.toml" | sed 's/.*/-\-add-data '\''&:.'\'/' | tr '\n' ' ') Apply this suggestion Suggestion importance[1-10]: 6 Why: The suggestion addresses a potential issue with file paths containing special characters, which could cause build failures. While valid, the current code already uses single quotes for the sed command.	6

💡 Need additional feedback ? start a PR chat