Refactor UnitTestGenerator to split into Generator & Validator #170
Assignees
Comments
EmbeddedDevops1
added
refactor
coderustic
added a commit
to coderustic/cover-agent
that referenced
this issue
Nov 10, 2024
Issue Codium-ai#170 aims to tackle the refactor of UnitTestGenerator and this is an attempt to split UnitTestGenerator into generator and validator. This PR is a first of a series of refactoring we can apply to UnitTestGenerator. * Created a new class `UnitTestValidator` by copying running, validating and processing coverage from `UnitTestGenerator` * Doesn't include any cleanup or optimization and kept the PR to be minimal structural changes. * Use prompt from UnitTestGenerator when storing a failed test into the database.
coderustic
added a commit
to coderustic/cover-agent
that referenced
this issue
Nov 10, 2024
Issue Codium-ai#170 aims to tackle the refactor of UnitTestGenerator and this is an attempt to split UnitTestGenerator into generator and validator. This PR is a first of a series of refactoring we can apply to UnitTestGenerator. * Created a new class `UnitTestValidator` by copying running, validating and processing coverage from `UnitTestGenerator` * Doesn't include any cleanup or optimization and kept the PR to be minimal structural changes. * Use prompt from UnitTestGenerator when storing a failed test into the database.
EmbeddedDevops1
pushed a commit
that referenced
this issue
Nov 10, 2024
Issue #170 aims to tackle the refactor of UnitTestGenerator and this is an attempt to split UnitTestGenerator into generator and validator. This PR is a first of a series of refactoring we can apply to UnitTestGenerator. * Created a new class `UnitTestValidator` by copying running, validating and processing coverage from `UnitTestGenerator` * Doesn't include any cleanup or optimization and kept the PR to be minimal structural changes. * Use prompt from UnitTestGenerator when storing a failed test into the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
UnitTestGeneratorhas too much functionality. From generating tests to validating. We should decompose the class into two separate classes. SayUnitTestGeneratorandUnitTestValidator.Let the
UnitTestGeneratorcontinue to return the generated tests toCoverAgentand letCoverAgentiterate the generated tests one-by-one and validate them.Also we could move
run_coverageinto aUnitTestValidatoras the generator does not use the coverage. Ideally, running coverage + processing coverage could be split into separate class which then can be used across CoverAgent, initialization of Validator and also while validating each test, but that could be a different issue.The text was updated successfully, but these errors were encountered: