Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add button name for accessibility #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErriGarcia
Copy link

@ErriGarcia ErriGarcia commented Jun 21, 2023

Problem:
When a button doesn't have an accessible name, screen readers announce it as "button", making it unusable for users who rely on screen readers.

Solution:
We have added an accessible name to the button element to ensure it is properly announced by screen readers. This will improve the accessibility and usability of the button for users who rely on assistive technologies.

Changes Made:
Updated the button's text content to provide a concise and understandable label using the props children.

Please review the changes and let us know if any further modifications or adjustments are required. I believe these updates will significantly improve the accessibility of the button for users with visual impairments.

Thank you for your attention to this matter.

@ttkapostol @ErriGarcia @NataliaBlanco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant