Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global.DependencyInjection should be an injection $dependencyInjection #27

Open
XavierBoubert opened this issue May 21, 2017 · 0 comments
Open

global.DependencyInjection should be an injection $dependencyInjection #27

XavierBoubert opened this issue May 21, 2017 · 0 comments
Labels
effort: medium (days) needs: pull request

Comments

@XavierBoubert
Copy link
Member

I'm submitting a... 

[ ] bug report
[x] feature request

Current behavior
DependencyInjection is a global variable.

Expected behavior
DependencyInjection should be an injection, like $dependencyInjection

What is the motivation / use case for changing the behavior?
To avoid globals

What are the allons-y modules are you using?
allons-y 1.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium (days) needs: pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XavierBoubert